You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/21 12:50:46 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #763: Impl `ops::Not` for `expr`
Jimexist opened a new pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Impl `ops::Not` for `expr` to make it more generic
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763#issuecomment-884474987
This appears to also have code from https://github.com/apache/arrow-datafusion/pull/761 in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb removed a comment on pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
alamb removed a comment on pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763#issuecomment-884474987
This appears to also have code from https://github.com/apache/arrow-datafusion/pull/761 in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763#discussion_r674313143
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1343,8 +1351,8 @@ impl Literal for ScalarValue {
}
macro_rules! make_literal {
- ($TYPE:ty, $SCALAR:ident) => {
- #[allow(missing_docs)]
+ ($TYPE:ty, $SCALAR:ident, $DOC: expr) => {
+ #[doc = $DOC]
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763#discussion_r693519729
##########
File path: python/src/functions.rs
##########
@@ -20,7 +20,7 @@ use crate::udf;
use crate::{expression, types::PyDataType};
use datafusion::arrow::datatypes::DataType;
use datafusion::logical_plan;
-use pyo3::{prelude::*, wrap_pyfunction};
+use pyo3::{prelude::*, types::PyTuple, wrap_pyfunction};
Review comment:
not really, let me rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763#discussion_r693161770
##########
File path: python/src/functions.rs
##########
@@ -20,7 +20,7 @@ use crate::udf;
use crate::{expression, types::PyDataType};
use datafusion::arrow::datatypes::DataType;
use datafusion::logical_plan;
-use pyo3::{prelude::*, wrap_pyfunction};
+use pyo3::{prelude::*, types::PyTuple, wrap_pyfunction};
Review comment:
Are the changes to python intended for this PR @Jimexist ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #763: Impl `ops::Not` for `expr`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #763:
URL: https://github.com/apache/arrow-datafusion/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org