You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 16:12:00 UTC
[GitHub] [airflow] Aakcht opened a new pull request #20172: Log provider import warnings as debug
Aakcht opened a new pull request #20172:
URL: https://github.com/apache/airflow/pull/20172
To avoid unnecessary warnings provider import errors can be logged as debug logs, see #14903. However, it was changed in #17625. This PR changes provider import errors log level back to debug again.
closes #20159
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20172: Log provider import warnings as debug
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20172:
URL: https://github.com/apache/airflow/pull/20172#issuecomment-990287094
Oh yeah. MS not really collaborating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #20172: Log provider import warnings as debug
Posted by GitBox <gi...@apache.org>.
Aakcht commented on pull request #20172:
URL: https://github.com/apache/airflow/pull/20172#issuecomment-990223184
I can try rebasing again if needed, but it looks like the failing check is not related to this PR:
```
error pulling image configuration: Get "https://centralus.data.mcr.microsoft.com/795a02ce1e3547eb8d4b8a7d06af7541-39qwoxxdjo//docker/registry/v2/blobs/sha256/47/47e4878b63746ba0df141688cce41aec224bd0d932ac073a0e04aba942b2bb4a/data?P1=1639081027&P2=1&P3=1&P4=CBIrt%2B7ZCG6tBfqEQ%2Fsx8i6D%2FgGxeFASAZsweCRI87A%3D&se=2021-12-09T20%3A17%3A07Z&sig=HwrQ9D05gihpTxESAfrurgpO%2FSp0RoC6fesv%2B16vTmA%3D&sp=r&spr=https&sr=b&sv=2016-05-31®id=795a02ce1e3547eb8d4b8a7d06af7541": dial tcp 204.79.197.219:443: i/o timeout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20172: Log provider import warnings as debug
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20172:
URL: https://github.com/apache/airflow/pull/20172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20172: Log provider import warnings as debug
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20172:
URL: https://github.com/apache/airflow/pull/20172#issuecomment-990207484
Yeah. I think there is indeed very little value to warn "early" here (if any) . Even if import error is "legitimate" (i.e. there is some real import error other than not installed libraries) then you would get error when you try to use the faulty class. Which is far better place for any problems like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20172: Log provider import warnings as debug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20172:
URL: https://github.com/apache/airflow/pull/20172#issuecomment-990205035
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org