You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/01/22 00:52:24 UTC
Review Request 30148: libprocess: Added O_CLOEXEC flag to os::open
calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30148/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-1432
https://issues.apache.org/jira/browse/MESOS-1432
Repository: mesos-git
Description
-------
libprocess: Added O_CLOEXEC flag to os::open calls.
Diffs
-----
3rdparty/libprocess/src/io.cpp 75fe75cfb00e0dc9d1dadea4fc6d6b9aea450fcb
3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
3rdparty/libprocess/src/tests/io_tests.cpp 4d304fe42fce749ffdf65f1c2412f2a01172c4e6
3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
Diff: https://reviews.apache.org/r/30148/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 30148: libprocess: Added O_CLOEXEC flag to
os::open calls.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30148/#review69094
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30148]
All tests passed.
- Mesos ReviewBot
On Jan. 21, 2015, 11:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30148/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 11:52 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1432
> https://issues.apache.org/jira/browse/MESOS-1432
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> libprocess: Added O_CLOEXEC flag to os::open calls.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 75fe75cfb00e0dc9d1dadea4fc6d6b9aea450fcb
> 3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
> 3rdparty/libprocess/src/tests/io_tests.cpp 4d304fe42fce749ffdf65f1c2412f2a01172c4e6
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/30148/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 30148: libprocess: Added O_CLOEXEC flag to
os::open calls.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30148/#review69101
-----------------------------------------------------------
Ship it!
Thanks for the cleanup!
- Jie Yu
On Jan. 21, 2015, 11:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30148/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 11:52 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1432
> https://issues.apache.org/jira/browse/MESOS-1432
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> libprocess: Added O_CLOEXEC flag to os::open calls.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 75fe75cfb00e0dc9d1dadea4fc6d6b9aea450fcb
> 3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
> 3rdparty/libprocess/src/tests/io_tests.cpp 4d304fe42fce749ffdf65f1c2412f2a01172c4e6
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp c2c9a5e47d37b5a3ac4b3326bde0548b5d0cbb29
>
> Diff: https://reviews.apache.org/r/30148/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>