[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6748: Minor: Encapsulate `return_type` and `signature` in `

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6748:
URL: https://github.com/apache/arrow-datafusion/pull/6748#discussion_r1238855825


##########
datafusion/expr/src/window_function.rs:
##########
@@ -246,10 +276,10 @@ mod tests {
     #[test]
     fn test_count_return_type() -> Result<()> {
         let fun = find_df_window_func("count").unwrap();
-        let observed = return_type(&fun, &[DataType::Utf8])?;
+        let observed = fun.return_type(&[DataType::Utf8])?;

Review Comment:
   This basically shows the new API -- use a method on the `fun` rather than have to find a free function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org