You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2026/06/09 14:14:23 UTC
[PR] feat(tui): Add theming support [datafusion-ballista]
martin-g opened a new pull request, #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850
# Which issue does this PR close?
Closes #1849
# Rationale for this change
Some users prefer light terminal background. Others - dark,
It would be good to support UI themes, so the users could change the colors of the application
# What changes are included in this PR?
Introduced Theme and settings.
A user could add something like:
```
theme:
name: dark
custom:
table_header: "red"
row_selected: 108
status_running: { r: 0, g: 128, b: 255 }
```
to their config and overwrite the defaults.
Two default themes are pre-defined: `dark` and `light`
# Are there any user-facing changes?
Only UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#discussion_r3393427048
##########
ballista-cli/src/tui/infrastructure/config.rs:
##########
@@ -81,10 +91,10 @@ impl Settings {
.format(FileFormat::Yaml)
.required(false),
)
- // Add in settings from the environment (with a prefix of BALLISTA_)
- // E.g. `BALLISTA_SCHEDULER_URL=http://localhost:50051 ballista_cli`
+ // Add in settings from the environment (with a prefix of `BALLISTA`.)
+ // E.g. `BALLISTA__SCHEDULER__URL=http://localhost:50051 ballista_cli`
Review Comment:
Why double underscores ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4669912747
Here is the default light theme:
<img width="1645" height="783" alt="image" src="https://github.com/user-attachments/assets/d27ba5a7-897a-4f2e-99e5-57de9ad85ed3" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4661293910
<img width="989" height="73" alt="image" src="https://github.com/user-attachments/assets/914010c3-a6fd-4abc-91a9-b6bec5b6d057" />
i got that log, not sure if its related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4678999313
i think this is good enough, having a way to hack the settings is good for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4661376705
ah sorry, did not see its still draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4667976337
> i got that log, not sure if its related
It is not related to the theming. It is introduced with https://github.com/apache/datafusion-ballista/pull/1808. I will fix !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4669915210
This is ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#discussion_r3394288614
##########
ballista-cli/src/tui/infrastructure/config.rs:
##########
@@ -81,10 +91,10 @@ impl Settings {
.format(FileFormat::Yaml)
.required(false),
)
- // Add in settings from the environment (with a prefix of BALLISTA_)
- // E.g. `BALLISTA_SCHEDULER_URL=http://localhost:50051 ballista_cli`
+ // Add in settings from the environment (with a prefix of `BALLISTA`.)
+ // E.g. `BALLISTA__SCHEDULER__URL=http://localhost:50051 ballista_cli`
Review Comment:
Because some of the properties use underscore, e.g. `table_header` and `app_background` and the `config` crate cannot resolve `BALLISTA_THEME_OVERRIDES_TABLE_HEADER_BG=color`
There was no such issue with the top level settings. BALLISTA_DATA_RELOAD_INTERVAL_MS=123 properly sets the `data_reload_interval_ms` setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4678923462
> One question, how do I change theme of web tui?
At the moment the only way is via query string:
`?ballista_theme_name=dark&ballista_theme_overrides_app_background_bg=darkgrey`
Only these two theme related settings are supported in the WebTUI. It is bit painful to parse those from the query string.
I am considering adding a new page/popup to the application for editing the config. In the first version it would be a simple TextArea that dumps the Settings struct as Yaml. On edit the Settings is updated and also stored in ~/.config/... (for TUI) and in localStorage for WebTUI. Asking the users to manipulate the localStorage via the browser console would be bad.
But as you said - the TUI is becoming more and more complex :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(tui): Add theming support [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1850:
URL: https://github.com/apache/datafusion-ballista/pull/1850#issuecomment-4679004631
let others contribute as well 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org