You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2018/01/28 22:17:10 UTC
mesos git commit: Replaced the `Os.Which` test to use `cat` rather
than `ping`.
Repository: mesos
Updated Branches:
refs/heads/master 25d269605 -> 981767895
Replaced the `Os.Which` test to use `cat` rather than `ping`.
Starting from Ubuntu 15.04, `ping` is not installed by default.
Rather than inducing a silly dependency, we'll test with `cat` instead.
Review: https://reviews.apache.org/r/65372
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/98176789
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/98176789
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/98176789
Branch: refs/heads/master
Commit: 981767895f1770701efeca3b8efd5c66cd34d8fc
Parents: 25d2696
Author: Michael Park <mp...@apache.org>
Authored: Sun Jan 28 12:41:22 2018 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Sun Jan 28 13:51:21 2018 -0800
----------------------------------------------------------------------
3rdparty/stout/tests/os_tests.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/98176789/3rdparty/stout/tests/os_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/tests/os_tests.cpp b/3rdparty/stout/tests/os_tests.cpp
index 11f1720..d92c8c3 100644
--- a/3rdparty/stout/tests/os_tests.cpp
+++ b/3rdparty/stout/tests/os_tests.cpp
@@ -1039,7 +1039,7 @@ TEST_F(OsTest, SYMLINK_Realpath)
TEST_F(OsTest, Which)
{
// TODO(jieyu): Test PATH search ordering and file execution bit.
- Option<string> which = os::which("ping");
+ Option<string> which = os::which("cat");
ASSERT_SOME(which);
which = os::which("bar");