You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/05/25 11:43:17 UTC

[GitHub] [royale-asjs] carlosrovira commented on pull request #841: Add BinaryImage to Jewel

carlosrovira commented on pull request #841:
URL: https://github.com/apache/royale-asjs/pull/841#issuecomment-633531249


   Hi,
   thanks for this contribution. I was reviewing it and looks good, just one thing to improve. It's good to have a Jewel version of BinaryImage so we can apply jewel styles on it, but the composing parts does not change, so we can use Basic pieces. Only in the case we need to add or change something we can extend and create a new class with the changes.
   Can you please apply this changes?
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org