You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/06/01 13:52:21 UTC

Review Request 48128: ATLAS-731 : Remove dashboard module in Atlas, replaced by dashboar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48128/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.


Bugs: ATLAS-731
    https://issues.apache.org/jira/browse/ATLAS-731


Repository: atlas


Description
-------

A new dashboard module (dashboardv2) was introduced in Atlas as part of ATLAS-582. This has been made the default UI module in ATLAS-672. The old module (dashboard) is still in the code and left commented. However, once we stabilize the new UI, we would like to remove the dashboard module.


Diffs
-----

  dashboard/.bowerrc 1d30a36 
  dashboard/.gitignore e5ee796 
  dashboard/.jshintignore efd063f 
  dashboard/.jshintrc d0c794d 
  dashboard/README.md 5285e19 
  dashboard/bower.json ef21c9b 
  dashboard/gruntfile.js ffe4767 
  dashboard/package.json 3772654 
  dashboard/pom.xml dea74b4 
  dashboard/public/css/common.css e545ad1 
  dashboard/public/css/d3tip.css 11e12b2 
  dashboard/public/css/details.css 59209de 
  dashboard/public/css/lineage.css ad7bf75 
  dashboard/public/css/login.css 89ebe41 
  dashboard/public/css/sticky-footer-navbar.css 2bab521 
  dashboard/public/css/tags.css 1d55592 
  dashboard/public/img/ApacheAtlasLogo.png 50c0ffdac67b4a7bc749ec701de43bf2a513b782 
  dashboard/public/img/addTag.png 5b012d5f92c8f49956062533056a296ff3e8f05e 
  dashboard/public/img/favicon.ico f0c22ad9bf0c7db2eaa899c41405a27f6b2281d5 
  dashboard/public/img/loader.gif 72a9b359720cda3df4aec673cb9dd0db9ab6d2dc 
  dashboard/public/img/logo-green.png fc3f2345a8032e72908d8667d1382f44bc2038dc 
  dashboard/public/img/process.png ec841afd3794e2d9d44713972972a3689ea50e15 
  dashboard/public/img/process1.png aeb123e1d31fc6de352c38f888f5e5d0555e64c3 
  dashboard/public/img/refresh.png 52ab75ec3e2638fd787ff2fdbdf6478b0ca8bb25 
  dashboard/public/img/select_arrow_img.png af272e6bedf118369a536508b42fb034e515914b 
  dashboard/public/img/spinner.gif 06fec2aff831eacc45aff5c0607e5adff71094f8 
  dashboard/public/img/tableicon.png d56d3285c4df1ec1655850411e5500cad46bbcf8 
  dashboard/public/img/tableicon1.png 6c9a9662cdfff985eb65e8a48abf1726d269efc4 
  dashboard/public/index.html cfd4e6d 
  dashboard/public/js/app.js 713952e 
  dashboard/public/js/config.js 6c66c7f 
  dashboard/public/js/init.js aa99935 
  dashboard/public/js/routes.js 8d0a3ac 
  dashboard/public/modules/about/aboutController.js 30ecaea 
  dashboard/public/modules/about/aboutModule.js 690994b 
  dashboard/public/modules/about/aboutResource.js ec3fdd8 
  dashboard/public/modules/about/views/about.html 2915b35 
  dashboard/public/modules/details/detailsController.js 0c09cd2 
  dashboard/public/modules/details/detailsModule.js 987750a 
  dashboard/public/modules/details/detailsResource.js 982cd1e 
  dashboard/public/modules/details/detailsRoutes.js 1886353 
  dashboard/public/modules/details/views/attribute.html 38c85b9 
  dashboard/public/modules/details/views/details.html 360c6cc 
  dashboard/public/modules/details/views/schema.html 22262fc 
  dashboard/public/modules/home/headerController.js 9edbd28 
  dashboard/public/modules/home/homeModule.js 017811c 
  dashboard/public/modules/home/views/header.html c5bac05 
  dashboard/public/modules/home/views/home.html 4e93782 
  dashboard/public/modules/lineage/lineageModule.js 4fda24d 
  dashboard/public/modules/lineage/lineageResource.js a376532 
  dashboard/public/modules/lineage/lineage_ioController.js 7ec0695 
  dashboard/public/modules/lineage/views/lineage.html 3b412f7 
  dashboard/public/modules/lineage/views/lineage_io.html 0f446f0 
  dashboard/public/modules/navigation/navigationController.js 0cfb50f 
  dashboard/public/modules/navigation/navigationModule.js 504eb1f 
  dashboard/public/modules/navigation/navigationResource.js 1f48aa3 
  dashboard/public/modules/navigation/views/navigation.html b7e1654 
  dashboard/public/modules/notification/notificationController.js d070029 
  dashboard/public/modules/notification/notificationModule.js cc7cbb0 
  dashboard/public/modules/notification/notificationService.js 0c198a0 
  dashboard/public/modules/notification/views/notifications.html f20b750 
  dashboard/public/modules/search/searchController.js 4e68d73 
  dashboard/public/modules/search/searchDirective.js 5c9fc48 
  dashboard/public/modules/search/searchModule.js ac82e3e 
  dashboard/public/modules/search/searchResource.js bac9bd4 
  dashboard/public/modules/search/searchRoutes.js 333648f 
  dashboard/public/modules/search/views/search.html 80116e9 
  dashboard/public/modules/search/views/searchResult.html 4638a27 
  dashboard/public/modules/search/views/types/column.html 3bbb6c0 
  dashboard/public/modules/search/views/types/db.html 28467b0 
  dashboard/public/modules/search/views/types/guid.html 483ca80 
  dashboard/public/modules/search/views/types/hiveLineage.html b150722 
  dashboard/public/modules/search/views/types/hive_table.html 84b747e 
  dashboard/public/modules/search/views/types/loadprocess.html 652cd97 
  dashboard/public/modules/search/views/types/storagedesc.html 0587f26 
  dashboard/public/modules/search/views/types/table.html a678ff9 
  dashboard/public/modules/search/views/types/view.html 1bf6fc7 
  dashboard/public/modules/tags/definition/definitionTagsController.js 40f77bc 
  dashboard/public/modules/tags/definition/definitionTagsModule.js eb2059f 
  dashboard/public/modules/tags/definition/tagAttributeDefinition.js d0d34e3 
  dashboard/public/modules/tags/definition/views/add.html 40d8d48 
  dashboard/public/modules/tags/instance/createTagController.js c16e08e 
  dashboard/public/modules/tags/instance/instanceTagsController.js 75414ab 
  dashboard/public/modules/tags/instance/instanceTagsModule.js 5f7083d 
  dashboard/public/modules/tags/instance/views/createTag.html 5937fb5 
  dashboard/public/modules/tags/instance/views/tags.html 77eb273 
  dashboard/public/modules/tags/tagClasses.js 375d911 
  dashboard/public/modules/tags/tagsModule.js 6bed79d 
  dashboard/public/modules/tags/tagsResource.js 02c0481 
  dashboard/public/modules/tags/tagsRoutes.js ebe1e87 
  pom.xml 6013cdc 
  webapp/pom.xml 5b023eb 
  webapp/src/main/webapp/index.html c248b79 

Diff: https://reviews.apache.org/r/48128/diff/


Testing
-------

Built the new codebae and checked that the old files are not packaged. Also checked that the existing UI is working fine.


Thanks,

keval bhatt


Re: Review Request 48128: ATLAS-731 : Remove dashboard module in Atlas, replaced by dashboar

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48128/#review135845
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 1, 2016, 1:52 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48128/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 1:52 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-731
>     https://issues.apache.org/jira/browse/ATLAS-731
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> A new dashboard module (dashboardv2) was introduced in Atlas as part of ATLAS-582. This has been made the default UI module in ATLAS-672. The old module (dashboard) is still in the code and left commented. However, once we stabilize the new UI, we would like to remove the dashboard module.
> 
> 
> Diffs
> -----
> 
>   dashboard/.bowerrc 1d30a36 
>   dashboard/.gitignore e5ee796 
>   dashboard/.jshintignore efd063f 
>   dashboard/.jshintrc d0c794d 
>   dashboard/README.md 5285e19 
>   dashboard/bower.json ef21c9b 
>   dashboard/gruntfile.js ffe4767 
>   dashboard/package.json 3772654 
>   dashboard/pom.xml dea74b4 
>   dashboard/public/css/common.css e545ad1 
>   dashboard/public/css/d3tip.css 11e12b2 
>   dashboard/public/css/details.css 59209de 
>   dashboard/public/css/lineage.css ad7bf75 
>   dashboard/public/css/login.css 89ebe41 
>   dashboard/public/css/sticky-footer-navbar.css 2bab521 
>   dashboard/public/css/tags.css 1d55592 
>   dashboard/public/img/ApacheAtlasLogo.png 50c0ffdac67b4a7bc749ec701de43bf2a513b782 
>   dashboard/public/img/addTag.png 5b012d5f92c8f49956062533056a296ff3e8f05e 
>   dashboard/public/img/favicon.ico f0c22ad9bf0c7db2eaa899c41405a27f6b2281d5 
>   dashboard/public/img/loader.gif 72a9b359720cda3df4aec673cb9dd0db9ab6d2dc 
>   dashboard/public/img/logo-green.png fc3f2345a8032e72908d8667d1382f44bc2038dc 
>   dashboard/public/img/process.png ec841afd3794e2d9d44713972972a3689ea50e15 
>   dashboard/public/img/process1.png aeb123e1d31fc6de352c38f888f5e5d0555e64c3 
>   dashboard/public/img/refresh.png 52ab75ec3e2638fd787ff2fdbdf6478b0ca8bb25 
>   dashboard/public/img/select_arrow_img.png af272e6bedf118369a536508b42fb034e515914b 
>   dashboard/public/img/spinner.gif 06fec2aff831eacc45aff5c0607e5adff71094f8 
>   dashboard/public/img/tableicon.png d56d3285c4df1ec1655850411e5500cad46bbcf8 
>   dashboard/public/img/tableicon1.png 6c9a9662cdfff985eb65e8a48abf1726d269efc4 
>   dashboard/public/index.html cfd4e6d 
>   dashboard/public/js/app.js 713952e 
>   dashboard/public/js/config.js 6c66c7f 
>   dashboard/public/js/init.js aa99935 
>   dashboard/public/js/routes.js 8d0a3ac 
>   dashboard/public/modules/about/aboutController.js 30ecaea 
>   dashboard/public/modules/about/aboutModule.js 690994b 
>   dashboard/public/modules/about/aboutResource.js ec3fdd8 
>   dashboard/public/modules/about/views/about.html 2915b35 
>   dashboard/public/modules/details/detailsController.js 0c09cd2 
>   dashboard/public/modules/details/detailsModule.js 987750a 
>   dashboard/public/modules/details/detailsResource.js 982cd1e 
>   dashboard/public/modules/details/detailsRoutes.js 1886353 
>   dashboard/public/modules/details/views/attribute.html 38c85b9 
>   dashboard/public/modules/details/views/details.html 360c6cc 
>   dashboard/public/modules/details/views/schema.html 22262fc 
>   dashboard/public/modules/home/headerController.js 9edbd28 
>   dashboard/public/modules/home/homeModule.js 017811c 
>   dashboard/public/modules/home/views/header.html c5bac05 
>   dashboard/public/modules/home/views/home.html 4e93782 
>   dashboard/public/modules/lineage/lineageModule.js 4fda24d 
>   dashboard/public/modules/lineage/lineageResource.js a376532 
>   dashboard/public/modules/lineage/lineage_ioController.js 7ec0695 
>   dashboard/public/modules/lineage/views/lineage.html 3b412f7 
>   dashboard/public/modules/lineage/views/lineage_io.html 0f446f0 
>   dashboard/public/modules/navigation/navigationController.js 0cfb50f 
>   dashboard/public/modules/navigation/navigationModule.js 504eb1f 
>   dashboard/public/modules/navigation/navigationResource.js 1f48aa3 
>   dashboard/public/modules/navigation/views/navigation.html b7e1654 
>   dashboard/public/modules/notification/notificationController.js d070029 
>   dashboard/public/modules/notification/notificationModule.js cc7cbb0 
>   dashboard/public/modules/notification/notificationService.js 0c198a0 
>   dashboard/public/modules/notification/views/notifications.html f20b750 
>   dashboard/public/modules/search/searchController.js 4e68d73 
>   dashboard/public/modules/search/searchDirective.js 5c9fc48 
>   dashboard/public/modules/search/searchModule.js ac82e3e 
>   dashboard/public/modules/search/searchResource.js bac9bd4 
>   dashboard/public/modules/search/searchRoutes.js 333648f 
>   dashboard/public/modules/search/views/search.html 80116e9 
>   dashboard/public/modules/search/views/searchResult.html 4638a27 
>   dashboard/public/modules/search/views/types/column.html 3bbb6c0 
>   dashboard/public/modules/search/views/types/db.html 28467b0 
>   dashboard/public/modules/search/views/types/guid.html 483ca80 
>   dashboard/public/modules/search/views/types/hiveLineage.html b150722 
>   dashboard/public/modules/search/views/types/hive_table.html 84b747e 
>   dashboard/public/modules/search/views/types/loadprocess.html 652cd97 
>   dashboard/public/modules/search/views/types/storagedesc.html 0587f26 
>   dashboard/public/modules/search/views/types/table.html a678ff9 
>   dashboard/public/modules/search/views/types/view.html 1bf6fc7 
>   dashboard/public/modules/tags/definition/definitionTagsController.js 40f77bc 
>   dashboard/public/modules/tags/definition/definitionTagsModule.js eb2059f 
>   dashboard/public/modules/tags/definition/tagAttributeDefinition.js d0d34e3 
>   dashboard/public/modules/tags/definition/views/add.html 40d8d48 
>   dashboard/public/modules/tags/instance/createTagController.js c16e08e 
>   dashboard/public/modules/tags/instance/instanceTagsController.js 75414ab 
>   dashboard/public/modules/tags/instance/instanceTagsModule.js 5f7083d 
>   dashboard/public/modules/tags/instance/views/createTag.html 5937fb5 
>   dashboard/public/modules/tags/instance/views/tags.html 77eb273 
>   dashboard/public/modules/tags/tagClasses.js 375d911 
>   dashboard/public/modules/tags/tagsModule.js 6bed79d 
>   dashboard/public/modules/tags/tagsResource.js 02c0481 
>   dashboard/public/modules/tags/tagsRoutes.js ebe1e87 
>   pom.xml 6013cdc 
>   webapp/pom.xml 5b023eb 
>   webapp/src/main/webapp/index.html c248b79 
> 
> Diff: https://reviews.apache.org/r/48128/diff/
> 
> 
> Testing
> -------
> 
> Built the new codebae and checked that the old files are not packaged. Also checked that the existing UI is working fine.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>