You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/21 02:31:28 UTC
[GitHub] [skywalking-agent-test-tool] dagmom commented on a change in pull request #17: Fix miss `%s` bug and modify noncompliant code
dagmom commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/17#discussion_r443175220
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/exception/TagValueNotEqualsException.java
##########
@@ -32,6 +32,6 @@ public TagValueNotEqualsException(String tagKey, String expected, String actual)
@Override
public String getCauseMessage() {
- return String.format("[tag(%s) value]: expected=>{}, actual=>{%s}\n", tagKey, expected, actual);
+ return String.format("[tag(%s) value]: expected=>{%s}, actual=>{%s}%n", tagKey, expected, actual);
Review comment:
I got suggestion by `SonarLint` and i think it's reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org