You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 21:09:24 UTC
[GitHub] [arrow] xhochy opened a new pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
xhochy opened a new pull request #8371:
URL: https://github.com/apache/arrow/pull/8371
FYI @nealrichardson
This probably won't work on first try but I hope to get fixes in before the release. I fear breakage with `cpp11` and `clang`-on-windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704852898
@xhochy you need to add the `r_config` param to all tasks using the same yml template. If you wan't to set it for just specific builds then handle it as an optional variable from jinja.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-718003614
> Update/add documentation about the conda builds to help with future maintenance.
I have no idea if/where we have this kind of documentation about the nightly builds, but we should have some. Maybe it belongs in `dev/README.md` or linked to there? If there is none, feel free to open a JIRA about it (and include a note in the JIRA about the connection between the R and pyarrow conda builds so we can document it there).
> Update the R documentation and install_arrow to reflect that there are conda nightlies
* https://github.com/apache/arrow/blob/master/r/README.md#installing-a-development-version
* https://github.com/apache/arrow/blob/master/r/vignettes/install.Rmd#L44
* https://github.com/apache/arrow/blob/master/r/R/install-arrow.R#L58-L59 make the outer check `if (conda)` and then inside that `if (nightly) { ... } else { ... }` to switch between the cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706516528
We can trigger crossbow in ~2h here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704556024
> > I fear breakage with `cpp11` and `clang`-on-windows.
>
> `cpp11` is header only, hopefully that helps?
Actually makes it worse as we need to compile everything of it with clang and clang is quite strict on Windows about everything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704835713
@kszucs Do you have an idea why my new `r_config` parameter doesn't work? I get the following traceback by the bot:
```
Cloning into '/tmp/tmpzsnkz8m4/arrow'...
From https://github.com/apache/arrow
* [new ref] refs/pull/8371/head -> ARROW-4960
Switched to branch 'ARROW-4960'
Cloning into '/tmp/tmpzsnkz8m4/crossbow'...
Traceback (most recent call last):
File "/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py", line 720, in render_files
rendered = template.render(task=self, **params)
File "/usr/share/miniconda/lib/python3.7/site-packages/jinja2/environment.py", line 1090, in render
self.environment.handle_exception()
File "/usr/share/miniconda/lib/python3.7/site-packages/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/usr/share/miniconda/lib/python3.7/site-packages/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "<template>", line 9, in top-level template code
jinja2.exceptions.UndefinedError: 'r_config' is undefined
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py", line 1653, in <module>
crossbow(obj={}, auto_envvar_prefix='CROSSBOW')
File "/usr/share/miniconda/lib/python3.7/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/usr/share/miniconda/lib/python3.7/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/share/miniconda/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/share/miniconda/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/share/miniconda/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/usr/share/miniconda/lib/python3.7/site-packages/click/decorators.py", line 33, in new_func
return f(get_current_context().obj, *args, **kwargs)
File "/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py", line 1439, in submit
config.validate()
File "/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py", line 1063, in validate
queue_remote_url='https://github.com/org/crossbow'
File "/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py", line 724, in render_files
path, e.__class__.__name__, str(e)
RuntimeError: Failed to render template `/tmp/tmpzsnkz8m4/arrow/dev/tasks/conda-recipes/azure.linux.yml` with UndefinedError: 'r_config' is undefined
Command '['/tmp/tmpzsnkz8m4/arrow/dev/tasks/crossbow.py', '--queue-path', '/tmp/tmpzsnkz8m4/crossbow', '--output-file', '/home/runner/work/arrow/arrow/result.yml', 'submit', '--job-prefix', 'actions', '--arrow-remote', 'https://github.com/xhochy/arrow.git', '--arrow-branch', 'ARROW-4960', 'conda-linux-gcc-py36-cpu']' returned non-zero exit status 1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704832356
@github-actions crossbow submit conda-linux-gcc-py36-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706541271
@nealrichardson Can you have a look at the R error on Windows? Do you have an idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704973438
@github-actions crossbow submit conda-linux-gcc-py36-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704556874
I also need to add it to the conda recipe but CI will probably fail much earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #8371:
URL: https://github.com/apache/arrow/pull/8371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705542256
Revision: 81d6c892451655584a33795032da388b3113328f
Submitted crossbow builds: [ursa-labs/crossbow @ actions-624](https://github.com/ursa-labs/crossbow/branches/all?query=actions-624)
|Task|Status|
|----|------|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-624-azure-conda-win-vs2017-py36)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707640462
Revision: e8ecb77eae1c302d65e9f3d68a380de32736e9d1
Submitted crossbow builds: [ursa-labs/crossbow @ actions-644](https://github.com/ursa-labs/crossbow/branches/all?query=actions-644)
|Task|Status|
|----|------|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-clean)|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-win-vs2017-py36)|
|conda-win-vs2017-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-win-vs2017-py37)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-644-azure-conda-win-vs2017-py38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704852898
@xhochy you need to add the `r_config` param to all tasks using the same yml template. If you wan't to set it for just specific builds then handle it as an optional variable from jinja (set a default value or check whether is it set or not).
Crossbow tries to render all tasks during the configuration validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707191975
@xhochy @nealrichardson I'm probably misunderstanding something but I'm somewhat surprised we need the symbols to be visible; `arrowExports.cpp` includes an explicit lookup table:
```c++
static const R_CallMethodDef CallEntries[] = {
// ...
{ "_arrow_all_record_batches", (DL_FUNC) &_arrow_all_record_batches, 1},
{ "_arrow_Table__from_record_batches", (DL_FUNC) &_arrow_Table__from_record_batches, 2},
{ "_arrow_Table__from_dots", (DL_FUNC) &_arrow_Table__from_dots, 2},
{ "_arrow_GetCpuThreadPoolCapacity", (DL_FUNC) &_arrow_GetCpuThreadPoolCapacity, 0},
{ "_arrow_SetCpuThreadPoolCapacity", (DL_FUNC) &_arrow_SetCpuThreadPoolCapacity, 1},
{NULL, NULL, 0}
};
extern "C" void R_init_arrow(DllInfo* dll){
R_registerRoutines(dll, NULL, CallEntries, NULL, NULL);
R_useDynamicSymbols(dll, FALSE);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707637662
@github-actions crossbow submit -g conda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706530420
@github-actions crossbow submit -g conda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705458926
@github-actions crossbow submit conda-win-vs2017-py36 conda-osx-clang-py37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-717922468
@nealrichardson Can you point me to the places where you want to have the two "documentation" bullet points from above written down? I'll add them then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707139891
@nealrichardson The issue is that `cpp11` doesn't have an equivalent to `RcppExport` which was used in the past. This is required for MSVC and clang-on-MSVC and a nice-to-have on Unixes.
CMake has an alternative way to produce these exports using `WINDOWS_EXPORT_ALL_SYMBOLS=ON` but we aren't using CMake here and I'm unable to find in the CMake sources what they are actually doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705626091
@bkietz can you take a look at that? Windows conda uses MSVC so it wouldn't surprise me if there were some corners in `cpp11` that weren't robust to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707193420
I'm also a bit confused why this is necessary but it was already the same situation with Rcpp and there things only worked once I've added `__declspec(dllexport)` to all the generated functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-717924309
@github-actions crossbow submit -g conda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704868371
Revision: b642d015ef7bf0b3780ced01ba162ed387e14d24
Submitted crossbow builds: [ursa-labs/crossbow @ actions-608](https://github.com/ursa-labs/crossbow/branches/all?query=actions-608)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-608-azure-conda-linux-gcc-py36-cpu)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707596871
Revision: 478c82ff0f340191a6e45ff6322267fd6d6118aa
Submitted crossbow builds: [ursa-labs/crossbow @ actions-643](https://github.com/ursa-labs/crossbow/branches/all?query=actions-643)
|Task|Status|
|----|------|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-643-azure-conda-win-vs2017-py36)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-722565090
JNI failure is unrelated, merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705626091
@bkietz can you take a look at that? Windows conda uses MSVC so it wouldn't surprise me if there were some corners in `cpp11` that weren't robust to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r500617928
##########
File path: dev/tasks/conda-recipes/r-arrow/configure.win
##########
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+set -euxo pipefail
+
+echo "PKG_CPPFLAGS=-DNDEBUG -I\"${LIBRARY_PREFIX}/include\" -I\"${PREFIX}/include\" -DARROW_R_WITH_ARROW" > src/Makevars.win
Review comment:
assuming arrow-cpp is built with `ARROW_S3=ON`, do this:
```suggestion
echo "PKG_CPPFLAGS=-DNDEBUG -I\"${LIBRARY_PREFIX}/include\" -I\"${PREFIX}/include\" -DARROW_R_WITH_ARROW -DARROW_R_WITH_S3" > src/Makevars.win
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r518166194
##########
File path: r/R/install-arrow.R
##########
@@ -56,7 +56,11 @@ install_arrow <- function(nightly = FALSE,
if (sysname %in% c("windows", "darwin", "linux")) {
if (conda && !nightly) {
Review comment:
```suggestion
if (conda) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked const, but MSVC's impl of `std::copy` marks its [arguments const](https://github.com/microsoft/STL/blob/3d88a64538827700e50c757877eb8413338ec281/stl/inc/xmemory#L1557). We'd probably be able to workaround this in `*Input`. I'll open an issue upstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706382865
Great! Can we apply that patch to https://github.com/conda-forge/r-cpp11-feedstock, and then this will work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705728943
It's actually clang-with-MSVC headers ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704554458
@github-actions crossbow submit conda-linux-gcc-py36-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704917987
Revision: 578e678ef7daa9b266f846566f52e68d9c0cd63e
Submitted crossbow builds: [ursa-labs/crossbow @ actions-610](https://github.com/ursa-labs/crossbow/branches/all?query=actions-610)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-610-azure-conda-linux-gcc-py36-cpu)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706095916
I can happily report that the iterator is the only issue and the build passes locally for me when I add a `const` at the end of the declaration and to all implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705541281
@github-actions crossbow submit conda-win-vs2017-py36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706516461
See https://github.com/conda-forge/r-cpp11-feedstock/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r503381879
##########
File path: dev/tasks/conda-recipes/r-arrow/build_win.sh
##########
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+set -exuo pipefail
+
+
+# Rename arrow.dll to lib_arrow.dll to avoid conflicts with the arrow-cpp arrow.dll
+sed -i -e 's/R_init_arrow/R_init_lib_arrow/g' r/src/arrowExports.cpp
Review comment:
```suggestion
sed -i -e 's/void R_init_arrow/__declspec(dllexport) void R_init_lib_arrow/g' r/src/arrowExports.cpp
```
Maybe lookup of the *init* is failing silently, then falling back to dynamic lookup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz edited a comment on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz edited a comment on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked const, but MSVC's impl of `std::copy` marks its [arguments const](https://github.com/microsoft/STL/blob/3d88a64538827700e50c757877eb8413338ec281/stl/inc/xmemory#L1557). We'd probably be able to workaround this in `*Input`. Upstream issue: https://github.com/r-lib/cpp11/issues/113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r503829529
##########
File path: dev/tasks/conda-recipes/r-arrow/build_win.sh
##########
@@ -0,0 +1,8 @@
+#!/bin/bash
+
+set -exuo pipefail
+
+
+# Rename arrow.dll to lib_arrow.dll to avoid conflicts with the arrow-cpp arrow.dll
+sed -i -e 's/R_init_arrow/R_init_lib_arrow/g' r/src/arrowExports.cpp
Review comment:
Massive! This worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706530648
Revision: 81d6c892451655584a33795032da388b3113328f
Submitted crossbow builds: [ursa-labs/crossbow @ actions-637](https://github.com/ursa-labs/crossbow/branches/all?query=actions-637)
|Task|Status|
|----|------|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-clean)|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-win-vs2017-py36)|
|conda-win-vs2017-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-win-vs2017-py37)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-637-azure-conda-win-vs2017-py38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705578867
Windows fails with
```
In file included from arrowExports.cpp:2:
In file included from D:/bld/r-arrow_1602163814614/_h_env/Lib/R/library/cpp11/include\cpp11.hpp:5:
In file included from D:/bld/r-arrow_1602163814614/_h_env/Lib/R/library/cpp11/include\cpp11/as.hpp:5:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\memory:6:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\xmemory:217:75: error: indirection requires pointer operand ('const cpp11::r_vector<int>::const_iterator' invalid)
_Uses_default_construct_t<_Alloc, decltype(_Unfancy(_UDest)), decltype(*_UFirst)>()));
^~~~~~~~
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\vector:1823:11: note: in instantiation of function template specialization 'std::_Uninitialized_copy<cpp11::r_vector<int>::const_iterator, int *, std::allocator<int> >' requested here
return (_Uninitialized_copy(_First, _Last, _Dest, this->_Getal()));
^
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\vector:708:22: note: in instantiation of function template specialization 'std::vector<int, std::allocator<int> >::_Ucopy<cpp11::r_vector<int>::const_iterator>' requested here
this->_Mylast() = _Ucopy(_First, _Last, this->_Myfirst());
^
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\vector:723:3: note: in instantiation of function template specialization 'std::vector<int, std::allocator<int> >::_Range_construct_or_tidy<cpp11::r_vector<int>::const_iterator>' requested here
_Range_construct_or_tidy(_Get_unwrapped(_First), _Get_unwrapped(_Last), _Iter_cat_t<_Iter>{});
^
D:/bld/r-arrow_1602163814614/_h_env/Lib/R/library/cpp11/include\cpp11/r_vector.hpp:945:10: note: in instantiation of function template specialization 'std::vector<int, std::allocator<int> >::vector<cpp11::r_vector<int>::const_iterator, void>' requested here
return {obj.begin(), obj.end()};
^
././arrow_cpp11.h:217:57: note: in instantiation of function template specialization 'cpp11::as_cpp<std::vector<int, std::allocator<int> >, int>' requested here
explicit ConstReferenceInput(SEXP from) : obj_(cpp11::as_cpp<T>(from)) {}
^
arrowExports.cpp:4411:49: note: in instantiation of member function 'arrow::r::ConstReferenceInput<std::vector<int, std::allocator<int> > >::ConstReferenceInput' requested here
arrow::r::Input<const std::vector<int>&>::type column_indices(column_indices_sexp);
^
1 error generated.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked const, but MSVC's impl of `std::copy` marks its [arguments const](https://github.com/microsoft/STL/blob/3d88a64538827700e50c757877eb8413338ec281/stl/inc/xmemory#L1557). We'd probably be able to workaround this in `*Input`. I'll open an issue upstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706395120
> Great! Can we apply that patch to https://github.com/conda-forge/r-cpp11-feedstock, and then this will work?
Yes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705458926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704979031
Revision: 7361f6fb227c35d804b7a243c5ff35c1acce57bd
Submitted crossbow builds: [ursa-labs/crossbow @ actions-612](https://github.com/ursa-labs/crossbow/branches/all?query=actions-612)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py36-cpu)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-715463399
@xhochy what's the status of this? Can we get this merged soon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705459887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#discussion_r501171547
##########
File path: dev/tasks/conda-recipes/r-arrow/build_win.sh
##########
@@ -0,0 +1,15 @@
+#!/bin/bash
+
+set -exuo pipefail
+
+# Patch Rcpp
+# https://github.com/RcppCore/Rcpp/pull/1069
+sed -i -e 's; abs; std::abs;g' $BUILD_PREFIX/Lib/R/library/Rcpp/include/Rcpp/DataFrame.h
Review comment:
```suggestion
```
##########
File path: dev/tasks/conda-recipes/r-arrow/build_win.sh
##########
@@ -0,0 +1,15 @@
+#!/bin/bash
+
+set -exuo pipefail
+
+# Patch Rcpp
+# https://github.com/RcppCore/Rcpp/pull/1069
+sed -i -e 's; abs; std::abs;g' $BUILD_PREFIX/Lib/R/library/Rcpp/include/Rcpp/DataFrame.h
+
+# Rename arrow.dll to lib_arrow.dll to avoid conflicts with the arrow-cpp arrow.dll
+sed -i -e 's/R_init_arrow/R_init_lib_arrow/g' r/src/arrowExports.cpp
+sed -i -e 's/useDynLib(arrow/useDynLib(lib_arrow/g' r/NAMESPACE
+
+# Make exported symbols visible
+# This needs to be patched in https://github.com/wch/r-source/blob/trunk/src/include/R_ext/Visibility.h
+sed -i -e 's/attribute_visible/__declspec(dllexport)/g' $BUILD_PREFIX/Lib/R/library/Rcpp/include/RcppCommon.h
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706566639
@xhochy one other suggestion: if this patch means we'll now have nightly conda R packages, can you edit the language in r/README.md and r/vignettes/install.Rmd about nightlies (and the lack of nightlies for conda)? And ideally edit https://github.com/apache/arrow/blob/master/r/R/install-arrow.R#L58-L60 in install_arrow() to point to the nightly conda repo too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-717925602
Revision: eae0f48c0d547b9a14d73aad82a15dbfb90bd255
Submitted crossbow builds: [ursa-labs/crossbow @ actions-684](https://github.com/ursa-labs/crossbow/branches/all?query=actions-684)
|Task|Status|
|----|------|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-clean)|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-win-vs2017-py36)|
|conda-win-vs2017-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-win-vs2017-py37)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-684-azure-conda-win-vs2017-py38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704867308
@github-actions crossbow submit conda-linux-gcc-py36-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704554783
> I fear breakage with `cpp11` and `clang`-on-windows.
`cpp11` is header only, hopefully that helps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706669698
Ah, I guess I need to some different magic again to export the C++ symbols. On Windows/MSVC they need to be explicitly exported in contrary to all other toolchains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705459887
Revision: 1ef678814ef792433fd9df98ffd0398af6f1ae47
Submitted crossbow builds: [ursa-labs/crossbow @ actions-622](https://github.com/ursa-labs/crossbow/branches/all?query=actions-622)
|Task|Status|
|----|------|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-622-azure-conda-osx-clang-py37)|
|conda-win-vs2017-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-622-azure-conda-win-vs2017-py36)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706517523
https://issues.apache.org/jira/browse/ARROW-4960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-706566299
> @nealrichardson Can you have a look at the R error on Windows? Do you have an idea?
https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=18698&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=41795ef0-6501-5db4-3ad4-33c0cf085626&l=1403
https://github.com/apache/arrow/blob/master/r/R/arrowExports.R#L1592
I think this is just the first C++ function being called, not something special about it. So that suggests to me that something's wrong about r/src/arrowExports.cpp, and since this is windows only, perhaps something is off with the `sed`s in build_win.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-707595145
@github-actions crossbow submit conda-win-vs2017-py36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-704913341
@github-actions crossbow submit conda-linux-gcc-py36-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz edited a comment on pull request #8371: WIP: ARROW-4960: [R] Build r-arrow conda package in crossbow
Posted by GitBox <gi...@apache.org>.
bkietz edited a comment on pull request #8371:
URL: https://github.com/apache/arrow/pull/8371#issuecomment-705748359
unfortunately `cpp11::r_vector::const_iterator::operator*` is not marked const, but MSVC's impl of `std::copy` marks its [arguments const](https://github.com/microsoft/STL/blob/3d88a64538827700e50c757877eb8413338ec281/stl/inc/xmemory#L1557). We'd probably be able to workaround this in `*Input`. Upstream issue: https://github.com/r-lib/cpp11/issues/113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org