You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/07/17 11:54:15 UTC

[GitHub] [avro] sarutak opened a new pull request, #2354: AVRO-3800: [Rust] profile section should be declared in the root package.

sarutak opened a new pull request, #2354:
URL: https://github.com/apache/avro/pull/2354

   AVRO-3800
   
   ## What is the purpose of the change
   
   This PR fixes an issue that [profile.release] declared in `wasm-demo/Cargo.toml` is ignored.
   In that section, `opt-level = "s"` is specified but it's ignored.
   
   ```
   $ cargo test -v --test demos --release
   ...
        Running `rustc --crate-name hello_wasm ... opt-level=3 ...`
        Running `rustc --crate-name demos ... opt-level=3 ...`
   ```
   
   To fix this issue, this change moves the section to `Cargo.toml` of the root package.
   
   ## Verifying this change
   
   After this change is applied, we can confirm that opt-level is changed as expected.
   ```
   $ cargo test -v --test demos --release
   ...
        Running `rustc --crate-name hello_wasm ... opt-level=s ...`
        Running `rustc --crate-name demos ... opt-level=s ...`
   ```
   
   ## Documentation
   
   No new docs as this PR introduces no new features.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #2354: AVRO-3800: [Rust] profile section should be declared in the root package

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2354:
URL: https://github.com/apache/avro/pull/2354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] sarutak commented on pull request #2354: AVRO-3800: [Rust] profile section should be declared in the root package

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #2354:
URL: https://github.com/apache/avro/pull/2354#issuecomment-1638078420

   [This doc](https://doc.rust-lang.org/cargo/reference/profiles.html#profiles) says like as follows.
   ```
   Cargo only looks at the profile settings in the Cargo.toml manifest at the root of the workspace. Profile settings defined in dependencies will be ignored.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #2354: AVRO-3800: [Rust] profile section should be declared in the root package

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2354:
URL: https://github.com/apache/avro/pull/2354#issuecomment-1638064173

   Do you have some reference to Cargo documentation explaining that this is the correct way ?
   To me this looks like a bug in `cargo` that it ignores the package specific settings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #2354: AVRO-3800: [Rust] profile section should be declared in the root package

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2354:
URL: https://github.com/apache/avro/pull/2354#issuecomment-1638090615

   Thank you, @sarutak !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org