You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Tim McConnell (JIRA)" <ji...@apache.org> on 2009/03/01 17:33:12 UTC
[jira] Created: (OPENJPA-946) Oracle create table(s) exceptions
Oracle create table(s) exceptions
---------------------------------
Key: OPENJPA-946
URL: https://issues.apache.org/jira/browse/OPENJPA-946
Project: OpenJPA
Issue Type: Sub-task
Reporter: Tim McConnell
Assignee: Tim McConnell
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Ravi P Palacherla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708885#action_12708885 ]
Ravi P Palacherla commented on OPENJPA-946:
-------------------------------------------
Thanks for the patch Tim.
It worked fine for me.
I was trying to run TestEJBState which is failing because of this error.
After applying your patch I no more see this issue.
I am getting a new exception, ORA-02275(different from above), so I will open a new JIRA for this.
Regards,
Ravi.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Ravi P Palacherla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi P Palacherla updated OPENJPA-946:
--------------------------------------
Comment: was deleted
(was: Hi,
I was trying to run TestEJBState against oracleDB and I need to get this JIRA issue fixed as part of it.
So, I spent some time and I think I can do one of the two things to get this fixed:
1) To change the "openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/kernel/common/apps/ProxiesPC.java" to replace the variable name of "date" to something like "date0." ( this is more like a workaround rather than an actual fix.)
2) I found the cause of this issue but I need some one to please review my proposed fix before I submit the patch.
The actual fix should go inside "correctName(Table table, Column col)" method of class "openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/MappingDefaultsImpl.java"
If you check the method , "col.setName(dict.getValidColumnName(name, table));" is called only if _defMissing is false. But "_defMissing" is set to true from "PersistenceMappingDefaults.java".
"_defMissing" represents DefaultMissingInfo and as per the doc, DefaultMissingInfo is to determine Whether to default missing column and table names rather than throw an exception.
So, if "_defMissing" is true then we have to set the column name properly rather than throwing exception ( For example, if column uses reserve word then we have to replace the column name.)
But here the opposite is happening meaning, we are changing the column name only if the "_defMissing" is false.
So, the resolution would be to change correctName to:
protected void correctName(Table table, Column col) {
if (_defMissing || _removeHungarianNotation) // Replaced !_defMissing with _defMissing )
{
String name = col.getName();
if (_removeHungarianNotation)
name = removeHungarianNotation(name);
col.setName(dict.getValidColumnName(name, table));
}
}
Also as stated under (http://n2.nabble.com/Question-regarding-DefaultMissingInfo-of-MappingDefaults-property.-td2657689.html)
I also tried to use
case 1: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=true)"/> or
case 2: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=false)"/> or
case 3: <property name="openjpa.jdbc.MappingDefaults" value="jpa"/> ( default)
but it did not help; meaning none of the above cases chaged the value of "_defMissing" and hence "col.setName(dict.getValidColumnName(name, table));" is not called, which is the cause of the issue.
Can someone please review the change before I submit the patch.
The reason for asking someone to review is because I think I did not understand the concept DefaultMissingInfo properly.
Thanks,
Ravi.)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946-3.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946-5.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708964#action_12708964 ]
Tim McConnell commented on OPENJPA-946:
---------------------------------------
Hi Ravi, thanks for reviewing and testing it. I'll add some javadoc today and update per your comments. I'm now getting the same ORA-02275 errors that you're seeing. Plus, I'm now getting many of these errors below. Do you know what this error is or what might be causing it ??
testAttrOverride1(org.apache.openjpa.persistence.embed.attrOverrides.TestAttrOverrides) Time elapsed: 0.157 sec <<< ERROR!
<openjpa-2.0.0-SNAPSHOT-r422266:774177M fatal store error> org.apache.openjpa.util.StoreException: Cannot create PoolableConnectionFactory (Listener refused the connection with the following error:
ORA-12518, TNS:listener could not hand off client connection
The Connection descriptor used by the client was:
9.51.245.122:1521:XE
I altered my Oracle database settings via this command but it did not seem to help:
"ALTER SYSTEM SET PROCESSES=500 SCOPE=SPFILE;"
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved OPENJPA-946.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0.0-M2)
2.0.0
Committed patch from 20090622 to 1.3.x and trunk. Thanks Tim.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Donald Woods
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OPENJPA-946) Oracle create table(s)
exceptions
Posted by "Ravi P Palacherla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700635#action_12700635 ]
Ravi P Palacherla edited comment on OPENJPA-946 at 4/19/09 7:09 PM:
--------------------------------------------------------------------
Hi,
I was trying to run TestEJBState against oracleDB and I need to get this JIRA issue fixed as part of it.
So, I spent some time and I think I can do one of the two things to get this fixed:
1) To change the "openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/kernel/common/apps/ProxiesPC.java" to replace the variable name of "date" to something like "date0." ( this is more like a workaround rather than an actual fix.)
2) I found the cause of this issue but I need some one to please review my proposed fix before I submit the patch.
The actual fix should go inside "correctName(Table table, Column col)" method of class "openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/MappingDefaultsImpl.java"
If you check the method , "col.setName(dict.getValidColumnName(name, table));" is called only if _defMissing is false. But "_defMissing" is set to true from "PersistenceMappingDefaults.java".
"_defMissing" represents DefaultMissingInfo and as per the doc, DefaultMissingInfo is to determine Whether to default missing column and table names rather than throw an exception.
So, if "_defMissing" is true then we have to set the column name properly rather than throwing exception ( For example, if column uses reserve word then we have to replace the column name.)
But here the opposite is happening meaning, we are changing the column name only if the "_defMissing" is false.
So, the resolution would be to change correctName to:
protected void correctName(Table table, Column col) {
if (_defMissing || _removeHungarianNotation) // Replaced !_defMissing with _defMissing )
{
String name = col.getName();
if (_removeHungarianNotation)
name = removeHungarianNotation(name);
col.setName(dict.getValidColumnName(name, table));
}
}
Also as stated under (http://n2.nabble.com/Question-regarding-DefaultMissingInfo-of-MappingDefaults-property.-td2657689.html)
I also tried to use
case 1: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=true)"/> or
case 2: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=false)"/> or
case 3: <property name="openjpa.jdbc.MappingDefaults" value="jpa"/> ( default)
but it did not help; meaning none of the above cases chaged the value of "_defMissing" and hence "col.setName(dict.getValidColumnName(name, table));" is not called, which is the cause of the issue.
Can someone please review the change before I submit the patch.
The reason for asking someone to review is because I think I did not understand the concept DefaultMissingInfo properly.
Thanks,
Ravi.
was (Author: rpalache):
Hi,
I was trying to run TestEJBState against oracleDB and I need to get this JIRA issue fixed as part of it.
So, I spent some time and I think I can do one of the two things to get this fixed:
1) To change the "openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/kernel/common/apps/ProxiesPC.java" to replace the variable name of "date" to something like "date0." ( this is more like a workaround rather than an actual fix.)
2) I found the cause of this issue but I need some one to please review my proposed fix before I submit the patch.
The actual fix should go inside "correctName(Table table, Column col)" method of class "openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/MappingDefaultsImpl.java"
If you check the method , "col.setName(dict.getValidColumnName(name, table));" is called only if _defMissing is false. But "_defMissing" is set to true from "PersistenceMappingDefaults.java".
"_defMissing" represents DefaultMissingInfo and as per the doc, DefaultMissingInfo is to determine Whether to default missing column and table names rather than throw an exception.
So, if "_defMissing" is true then we have to set the column name properly rather than throwing exception ( For example, if column uses reserve word then we have to replace the column name.)
But here the opposite is happening meaning, we are changing the column name only if the "_defMissing" is false.
So, the resolution would be to change correctName to:
protected void correctName(Table table, Column col) {
if (_defMissing || _removeHungarianNotation) // Replaced !_defMissing with _defMissing )
{
String name = col.getName();
if (_removeHungarianNotation)
name = removeHungarianNotation(name);
col.setName(dict.getValidColumnName(name, table));
}
}
Also as stated under (http://n2.nabble.com/Question-regarding-DefaultMissingInfo-of-MappingDefaults-property.-td2657689.html)
I also tried to use
case 1: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=true)"/> or
case 2: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=false)"/> or
case 3: <property name="openjpa.jdbc.MappingDefaults" value="jpa"/> ( default)
but it did not help ( meaning none of the above cases chaged the value of "_defMissing" and hence "col.setName(dict.getValidColumnName(name, table));" is not called, which is the cause of the issue.
Can someone please review the change before I submit the patch.
The reason for asking someone to review is because I think I did not understand the concpet DefaultMissingInfo properly.
Thanks,
Ravi.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946-4.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946-5.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946.patch
Hi Ravi, Please try this patch. It will fix your Oracle "Create Table" errors when reserved keywords are used for column names. Please let me know how it goes. Thanks much
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OPENJPA-946) Oracle create table(s)
exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708964#action_12708964 ]
Tim McConnell edited comment on OPENJPA-946 at 5/13/09 9:11 AM:
----------------------------------------------------------------
Hi Michael, thanks for reviewing and testing it. I'll add some javadoc today and update per your comments. I'm now getting the same ORA-02275 errors that you're seeing. Plus, I'm now getting many of these errors below. Do you know what this error is or what might be causing it ??
testAttrOverride1(org.apache.openjpa.persistence.embed.attrOverrides.TestAttrOverrides) Time elapsed: 0.157 sec <<< ERROR!
<openjpa-2.0.0-SNAPSHOT-r422266:774177M fatal store error> org.apache.openjpa.util.StoreException: Cannot create PoolableConnectionFactory (Listener refused the connection with the following error:
ORA-12518, TNS:listener could not hand off client connection
The Connection descriptor used by the client was:
9.51.245.122:1521:XE
I altered my Oracle database settings via this command but it did not seem to help:
"ALTER SYSTEM SET PROCESSES=500 SCOPE=SPFILE;"
was (Author: mcconne):
Hi Ravi, thanks for reviewing and testing it. I'll add some javadoc today and update per your comments. I'm now getting the same ORA-02275 errors that you're seeing. Plus, I'm now getting many of these errors below. Do you know what this error is or what might be causing it ??
testAttrOverride1(org.apache.openjpa.persistence.embed.attrOverrides.TestAttrOverrides) Time elapsed: 0.157 sec <<< ERROR!
<openjpa-2.0.0-SNAPSHOT-r422266:774177M fatal store error> org.apache.openjpa.util.StoreException: Cannot create PoolableConnectionFactory (Listener refused the connection with the following error:
ORA-12518, TNS:listener could not hand off client connection
The Connection descriptor used by the client was:
9.51.245.122:1521:XE
I altered my Oracle database settings via this command but it did not seem to help:
"ALTER SYSTEM SET PROCESSES=500 SCOPE=SPFILE;"
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (OPENJPA-946) Oracle create table(s)
exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on OPENJPA-946 started by Tim McConnell.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946.patch
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677821#action_12677821 ]
Tim McConnell commented on OPENJPA-946:
---------------------------------------
Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: ORA-00904: : invalid identifier
{stmnt 12673179 CREATE TABLE PROX_PC (id NUMBER NOT NULL, date DATE, name VARCHAR2(255), sqlDate DATE, timestamp TIMESTAMP, PRIMARY KEY (id))} [code=904, state=42000]
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736726#action_12736726 ]
Donald Woods commented on OPENJPA-946:
--------------------------------------
Thanks for catching that Alan.
Updated TestResWordEntity.java in trunk as Rev798991 and 1.3.x as Rev798993.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Donald Woods
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679547#action_12679547 ]
Milosz Tylenda commented on OPENJPA-946:
----------------------------------------
Tim, have you checked the patch resolves the issue? I am afraid adding a DATE to Oracle will not help because:
1. The file sql-keywords.rsrc already contains the DATE word. This file contains reserved words defined by SQL spec and its contents are merged with database-specific reserved words.
2. Recently I hit a similar problem with Firebird database: many of our tests use entities with a property "value" and VALUE is an SQL reserved word (exists in the sql-keywords.rsrc) and also a Firebird reserved word.
Maybe we are not checking column names against reserved words or merging SQL words with database-specific ones is broken.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946-3.patch
This patch contains a JUnit testcase, which may or may not matter to Ravi, but should be the patch that gets committed.....
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708941#action_12708941 ]
Michael Dick commented on OPENJPA-946:
--------------------------------------
One other thing : OpenJPA > 1.0.x requires Java 5, so we can use generics. New code should take advantage of them to avoid misleading compiler warnings.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946.patch
Cleaned up dictionaries for these databases:
1. Derby
2. DB2
3. MySQL
4. Oracle
5. PostgreSQL
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946-2.patch
Hi Ravi, sorry about the first patch. Please discard it and try this patch. Let me know how it goes. Thanks much
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-2.patch, OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946-4.patch
Attached new patch and have incorporated as many of Mike's comments as possible. Please review again and let me know what you think. Thanks much
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch, OPENJPA-946-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated OPENJPA-946:
---------------------------------
Fix Version/s: (was: 2.0.0)
2.0.0-M3
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Donald Woods
> Fix For: 1.3.0, 2.0.0-M3
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708990#action_12708990 ]
Michael Dick commented on OPENJPA-946:
--------------------------------------
Hi Tim,
FWIW I've seen that error before and adding a connection pool really helped (tried this before doing the SET PROCESSES step).
If you're already using a connection pool you can try tweaking the settings (default values in pom.xml might not be perfect for Oracle XE).
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946-5.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned OPENJPA-946:
------------------------------------
Assignee: Donald Woods (was: Tim McConnell)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Donald Woods
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946.patch
The set of reserved words for the Oracle dictionary is incomplete which is causing this testcase to fail. In this particular testcase a column is named "date", which is reserved but not included in the reservedWordSet. This patch update the Oracle dictionary with all the reserved words.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated OPENJPA-946:
---------------------------------
Fix Version/s: 1.3.0
also included in 1.3.x as Rev778727
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-946-3.patch, OPENJPA-946-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946-2.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679658#action_12679658 ]
Tim McConnell commented on OPENJPA-946:
---------------------------------------
Hi Milosz, I did not know that. Thanks for pointing it out......
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708932#action_12708932 ]
Michael Dick commented on OPENJPA-946:
--------------------------------------
Some comments on the patch.
The method name getReservedColumnNames() is misleading. It's really returning the the set of reserved words - reserved words that can be used as column names. Renaming to getValidColumnNames() makes more sense to me. Javadoc would also help here - I had to go back to the declaration of the instance variable to figure out why the method was correct.
In addition this method recreates the list each time it's invoked - it'd be better to either cache the list after the first invocation or create the set when the dictionary is initialized.
I'm not sure I have a good solution at hand, but it looks like a lot of the dictionaries reuse the same set of allowable column names. It'd be nice if we could store that list in a single place instead of potentially maintaining it in each class.
Otherwise the patch looks good, thanks very much for looking into it Tim. The testcase is very nice and appreciated.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Alan Raison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736648#action_12736648 ]
Alan Raison commented on OPENJPA-946:
-------------------------------------
This patch seems to include a test case which tries to connect to a Derby server - not much good if you're not using Derby :(
See openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/dynamicschema/TestResWordEntity.java
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Donald Woods
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell reopened OPENJPA-946:
-----------------------------------
Reopening as there still appears to be a problem when using the mapping tool (SynchronizeMappings) and the SchemaFactory in its configuration.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946-3.patch, OPENJPA-946-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Patch Info: [Patch Available]
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: (was: OPENJPA-946.patch)
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Ravi P Palacherla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700635#action_12700635 ]
Ravi P Palacherla commented on OPENJPA-946:
-------------------------------------------
Hi,
I was trying to run TestEJBState against oracleDB and I need to get this JIRA issue fixed as part of it.
So, I spent some time and I think I can do one of the two things to get this fixed:
1) To change the "openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/kernel/common/apps/ProxiesPC.java" to replace the variable name of "date" to something like "date0." ( this is more like a workaround rather than an actual fix.)
2) I found the cause of this issue but I need some one to please review my proposed fix before I submit the patch.
The actual fix should go inside "correctName(Table table, Column col)" method of class "openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/MappingDefaultsImpl.java"
If you check the method , "col.setName(dict.getValidColumnName(name, table));" is called only if _defMissing is false. But "_defMissing" is set to true from "PersistenceMappingDefaults.java".
"_defMissing" represents DefaultMissingInfo and as per the doc, DefaultMissingInfo is to determine Whether to default missing column and table names rather than throw an exception.
So, if "_defMissing" is true then we have to set the column name properly rather than throwing exception ( For example, if column uses reserve word then we have to replace the column name.)
But here the opposite is happening meaning, we are changing the column name only if the "_defMissing" is false.
So, the resolution would be to change correctName to:
protected void correctName(Table table, Column col) {
if (_defMissing || _removeHungarianNotation) // Replaced !_defMissing with _defMissing )
{
String name = col.getName();
if (_removeHungarianNotation)
name = removeHungarianNotation(name);
col.setName(dict.getValidColumnName(name, table));
}
}
Also as stated under (http://n2.nabble.com/Question-regarding-DefaultMissingInfo-of-MappingDefaults-property.-td2657689.html)
I also tried to use
case 1: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=true)"/> or
case 2: <property name="openjpa.jdbc.MappingDefaults" value="default(DefaultMissingInfo=false)"/> or
case 3: <property name="openjpa.jdbc.MappingDefaults" value="jpa"/> ( default)
but it did not help ( meaning none of the above cases chaged the value of "_defMissing" and hence "col.setName(dict.getValidColumnName(name, table));" is not called, which is the cause of the issue.
Can someone please review the change before I submit the patch.
The reason for asking someone to review is because I think I did not understand the concpet DefaultMissingInfo properly.
Thanks,
Ravi.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work stopped: (OPENJPA-946) Oracle create table(s)
exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on OPENJPA-946 stopped by Tim McConnell.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946-3.patch, OPENJPA-946-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Ravi P Palacherla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708077#action_12708077 ]
Ravi P Palacherla commented on OPENJPA-946:
-------------------------------------------
Hi Tim,
I applied the patch in trunk version and
I am getting a compilation error saying:
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
D:\openJPAsrc\openjpa_trunk\trunk\openjpa-persistence-jdbc\src\test\java\org\apache\openjpa\persiste
nce\dynamicschema\TestDynamicSchemas.java:[195,28] cannot find symbol
symbol : method getReservedWords()
location: class org.apache.openjpa.jdbc.sql.DBDictionary
D:\openJPAsrc\openjpa_trunk\trunk\openjpa-persistence-jdbc\src\test\java\org\apache\openjpa\persiste
nce\dynamicschema\TestDynamicSchemas.java:[195,28] cannot find symbol
symbol : method getReservedWords()
location: class org.apache.openjpa.jdbc.sql.DBDictionary
Also, the fix only contains files in test cases.
So, will this fix work for an openJPA sample (outside test suites) that uses reserved words.
Thanks,
Ravi.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-946.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-946:
----------------------------------
Attachment: OPENJPA-946-5.patch
This patch will handle the case where column names are validated and translated against the database dictionary and multiple schema factories get invoked, including the DynamicSchemaFactory. Additionally, some changes have been made to the Derby (see http://db.apache.org/derby/docs/10.1/ref/rrefkeywords29722.html) and DB2 dictionaries. Thanks Jeremy for the testcase.
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 1.3.0, 2.0.0-M2
>
> Attachments: OPENJPA-946-5.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-946) Oracle create table(s) exceptions
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell resolved OPENJPA-946.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
> Oracle create table(s) exceptions
> ---------------------------------
>
> Key: OPENJPA-946
> URL: https://issues.apache.org/jira/browse/OPENJPA-946
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-946-3.patch, OPENJPA-946-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.