[GitHub] [flink-table-store] zjureel commented on a diff in pull request #479: [FLINK-30632] Introduce DataType for table store

[GitBox <gi...@apache.org>]

zjureel commented on code in PR #479:
URL: https://github.com/apache/flink-table-store/pull/479#discussion_r1067932747


##########
flink-table-store-benchmark/flink-table-store-micro-benchmarks/src/main/java/org/apache/flink/table/store/benchmark/file/mergetree/MergeTreeBenchmark.java:
##########
@@ -150,13 +149,19 @@ private RecordWriter<KeyValue> recreateMergeTree(
                             @Override
                             public List<DataField> keyFields(TableSchema schema) {
                                 return Collections.singletonList(
-                                        new DataField(0, "k", new AtomicDataType(new IntType())));
+                                        new DataField(

Review Comment:
   Will Table Store get rid of `RowType` and `org.apache.flink.table.types.logical.IntType` later?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org