You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org> on 2023/05/08 07:48:30 UTC
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9388: feat: proxy-mirror support grpc and grpcs
monkeyDluffy6017 commented on code in PR #9388:
URL: https://github.com/apache/apisix/pull/9388#discussion_r1187136254
##########
apisix/init.lua:
##########
@@ -688,6 +689,13 @@ function _M.grpc_access_phase()
core.log.error("failed to set grpcs upstream param: ", err)
core.response.exit(code)
end
+
+ if api_ctx.var.upstream_mirror_scheme == "grpc" or
+ api_ctx.var.upstream_mirror_scheme == "grpcs" then
+ if has_mod then
+ apisix_ngx_client.enable_mirror()
+ end
+ end
Review Comment:
Why do you enable mirror here? it should be set in `proxy-mirror` plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org