[jira] [Commented] (AIRFLOW-4087) Calling SUDO to remove temp cfg file failed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792184#comment-16792184 ] 

ASF GitHub Bot commented on AIRFLOW-4087:
-----------------------------------------

youngyjd commented on pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner
URL: https://github.com/apache/airflow/pull/4916
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4087
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   This PR is to remove sudo from the command `sudo rm /tmp/tmpcfgfile`called on task finish.
   
   ### Tests
   
   - [X] My PR adds the following does not need testing for this extremely good reason:
   Just to remove sudo
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Calling SUDO to remove temp cfg file failed
> -------------------------------------------
>
>                 Key: AIRFLOW-4087
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4087
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Junda Yang
>            Priority: Major
>
> At Lyft we use a non-root user (named *airflow* in our case) to run airflow worker and we keep getting emails saying that the user is not in sudoers so the command to remove temp airflow.cfg failed.
> {code:java}
> Mar 13 21:22:33 : airflow : user NOT in sudoers ; TTY=unknown ; PWD=/srv/airflowinfra ; USER=root ; COMMAND=/bin/rm /tmp/tmpgzw8eaww
> {code}
> I found that the error was generated due to [https://github.com/apache/airflow/blob/5a303ebbc572cee7c9c30be84ebf625357360d4b/airflow/task_runner/base_task_runner.py#L155-#L160] 
> Not having enough context, is there any reason airflow needs to run sudo to remove the file? If not, I think it should be safe to remove the sudo, because the temp file is owned by the same user who runs worker command.
> {code:java}
> jundayang@airflowinfraworker-production-iad-0184b3e28b386f0cf:/tmp$ ls -la tmpzyfuiw2v
> -rw------- 1 airflow airflow 7139 Mar 13 21:25 tmpzyfuiw2v
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)