You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/04/15 23:20:20 UTC
Review Request: Support bzip2 and XZ (LZMA) by launcher.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10491/
-----------------------------------------------------------
Review request for mesos.
Description
-------
Support bzip2 and XZ (LZMA) by launcher.
Diffs
-----
src/launcher/launcher.cpp bc50c5f
Diff: https://reviews.apache.org/r/10491/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews
Re: Review Request: Support bzip2 and XZ (LZMA) by launcher.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 15, 2013, 11:26 p.m., Vinod Kone wrote:
> > Ship It!
committed to trunk. please mark as submitted.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10491/#review19228
-----------------------------------------------------------
On April 15, 2013, 11:16 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10491/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 11:16 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Support bzip2 and XZ (LZMA) by launcher.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp bc50c5f
>
> Diff: https://reviews.apache.org/r/10491/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Support bzip2 and XZ (LZMA) by launcher.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10491/#review19228
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 15, 2013, 11:16 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10491/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 11:16 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Support bzip2 and XZ (LZMA) by launcher.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp bc50c5f
>
> Diff: https://reviews.apache.org/r/10491/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Support bzip2 and XZ (LZMA) by launcher.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10491/
-----------------------------------------------------------
(Updated April 15, 2013, 11:16 p.m.)
Review request for mesos.
Description
-------
Support bzip2 and XZ (LZMA) by launcher.
Diffs (updated)
-----
src/launcher/launcher.cpp bc50c5f
Diff: https://reviews.apache.org/r/10491/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews
Re: Review Request: Support bzip2 and XZ (LZMA) by launcher.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10491/#review19225
-----------------------------------------------------------
src/launcher/launcher.cpp
<https://reviews.apache.org/r/10491/#comment39818>
not yours, but can you fix this?
s/+ command/ << command/
src/launcher/launcher.cpp
<https://reviews.apache.org/r/10491/#comment39817>
s/+ command/ << command/
src/launcher/launcher.cpp
<https://reviews.apache.org/r/10491/#comment39820>
s/if/ If/
Also, we use line comments ("//") instead of block comments ("/*")
src/launcher/launcher.cpp
<https://reviews.apache.org/r/10491/#comment39819>
s/+ command/ << command/
- Vinod Kone
On April 15, 2013, 9:20 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10491/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:20 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Support bzip2 and XZ (LZMA) by launcher.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp bc50c5f
>
> Diff: https://reviews.apache.org/r/10491/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>