You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/27 12:45:32 UTC
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3198: Stm32h7 fix heap clobber
davids5 commented on a change in pull request #3198:
URL: https://github.com/apache/incubator-nuttx/pull/3198#discussion_r602714473
##########
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/flash.ld
##########
@@ -172,9 +172,12 @@ SECTIONS
/* Emit the the D3 power domain section for locating BDMA data */
- .sram4 :
- {
- } > sram4
+ .sram4_reserve :
Review comment:
```suggestion
.sram4_reserve (NOLOAD) :
```
A OK Once enabled
38000800 A _sram4_reserve_end
38000000 A _sram4_reserve_start
38000400 00000400 d g_spi6_rxbuf
38000000 00000400 d g_spi6_txbuf
Except:
-rwxrwxr-x 1 david_s5 david_s5 805308416 Mar 27 05:34 nuttx.bin
Yikes!
With **NOLOAD**
108 -rwxrwxr-x 1 david_s5 david_s5 108708 Mar 27 05:39 nuttx.bin
24000074 00000048 d g_spi6dev
38000400 00000400 b g_spi6_rxbuf
38000000 00000400 b g_spi6_txbuf
0800207e 0000001a T stm32_spi6select
08002098 00000018 T stm32_spi6status
38000800 A _sram4_reserve_end
38000000 A _sram4_reserve_start
##########
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/flash.ld
##########
@@ -172,9 +172,12 @@ SECTIONS
/* Emit the the D3 power domain section for locating BDMA data */
- .sram4 :
- {
- } > sram4
+ .sram4_reserve :
+ {
+ _sram4_reserve_start = ABSOLUTE(.);
Review comment:
I am wondering if we could use a name here that says what it is.
```
_sram4_heapexclude_start = ABSOLUTE(.);
*(.sram4)
_sram4_heapexclude_end = ABSOLUTE(.);
_sram4_heap_start = ABSOLUTE(.);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org