You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:42:53 UTC
[GitHub] [thrift] emmenlau opened a new pull request, #2654: Various minor improvements
emmenlau opened a new pull request, #2654:
URL: https://github.com/apache/thrift/pull/2654
This PR contains just three minor improvements in the build, mostly related to cmake. They should not harm in any way, and have been tested in different environments and on different platforms.
- [ ] No ticket for trivial changes
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2654: Various minor improvements
Posted by GitBox <gi...@apache.org>.
emmenlau commented on PR #2654:
URL: https://github.com/apache/thrift/pull/2654#issuecomment-1242651481
The build errors in Travis are unrelated. Since this PR should almost certainly not have a negative impact, merging despite a few failing builds in Travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau merged pull request #2654: Various minor improvements
Posted by GitBox <gi...@apache.org>.
emmenlau merged PR #2654:
URL: https://github.com/apache/thrift/pull/2654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org