You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mmorel-35 (via GitHub)" <gi...@apache.org> on 2024/05/11 08:40:00 UTC
[PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
mmorel-35 opened a new pull request, #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95
I pushed [skywalking-data-collect-protocol@9.7.0](https://github.com/bazelbuild/bazel-central-registry/pull/1671) in the BCR.
This provide the MODULE and patchprovided there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "mmorel-35 (via GitHub)" <gi...@apache.org>.
mmorel-35 commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597413956
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
I can remove this field or keep it empty.
If you decide to use https://github.com/bazel-contrib/publish-to-bcr it will be updated when you create the new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597413418
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
We have minor changes with versions, I am afraid we don't update this from version to version, because we don't use Brazil internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "mmorel-35 (via GitHub)" <gi...@apache.org>.
mmorel-35 commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597414444
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
Alright, what do you prefer then, just remove the field ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597441444
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
@wbpcode Could you check on this? cpp2sky is the only one using this tool(Brazel).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "mmorel-35 (via GitHub)" <gi...@apache.org>.
mmorel-35 closed pull request #95: chore(bazel): add MODULE.bazel files for bzlmod
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597414568
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
I will ask our maintainer of cpp SDK to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bazel): add MODULE.bazel files for bzlmod [skywalking-data-collect-protocol]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #95:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/95#discussion_r1597414322
##########
MODULE.bazel:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module(
+ name = "skywalking-data-collect-protocol",
+ version = "10.0.0",
Review Comment:
We don't have this release plan at there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org