You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/22 13:24:03 UTC
[GitHub] [shardingsphere] cherrylzhao opened a new pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
cherrylzhao opened a new pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764
- add wait-for-it.sh
- optimize docker file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429512258
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
@kezhenxu94 Hi, thanks for your kind remainder, and sorry for my lax checking. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#issuecomment-632711089
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=h1) Report
> Merging [#5764](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/df08f42a91ebac300edf755140d90584972d43eb&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5764 +/- ##
============================================
- Coverage 53.20% 52.94% -0.26%
- Complexity 431 437 +6
============================================
Files 1168 1176 +8
Lines 20572 20665 +93
Branches 3708 3730 +22
============================================
- Hits 10945 10941 -4
- Misses 8958 9055 +97
Partials 669 669
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/proxy/backend/schema/ShardingSphereSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWFzLmphdmE=) | `26.92% <0.00%> (-3.85%)` | `0.00% <0.00%> (ø%)` | |
| [.../db/protocol/mysql/payload/MySQLPacketPayload.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BheWxvYWQvTXlTUUxQYWNrZXRQYXlsb2FkLmphdmE=) | `93.39% <0.00%> (-3.67%)` | `0.00% <0.00%> (ø%)` | |
| [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ere/proxy/backend/schema/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...e/infra/executor/sql/group/ExecuteGroupEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9ncm91cC9FeGVjdXRlR3JvdXBFbmdpbmUuamF2YQ==) | `92.10% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...proxy/backend/executor/BackendExecutorContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGVjdXRvci9CYWNrZW5kRXhlY3V0b3JDb250ZXh0LmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...xy/backend/text/admin/BroadcastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0Jyb2FkY2FzdEJhY2tlbmRIYW5kbGVyLmphdmE=) | `85.71% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...pache/shardingsphere/replica/rule/ReplicaRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...hardingsphere/replica/rule/ReplicaRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVwbGljYS9zaGFyZGluZ3NwaGVyZS1yZXBsaWNhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVwbGljYS9ydWxlL1JlcGxpY2FSdWxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/5764/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=footer). Last update [df08f42...9d093d2](https://codecov.io/gh/apache/shardingsphere/pull/5764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429513721
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
fix it at #5765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429512439
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
ok, I'll revise it later, it's better wget it in docker file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kezhenxu94 commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429511765
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
I don't think you can simply add a license header when you copy a file from others, especially it's not licensed with AL2.0 originally
https://github.com/vishnubob/wait-for-it/blob/master/wait-for-it.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kezhenxu94 commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429511765
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
I don't think you can simply add a license header when you copy a file from others, especially it's not licensed with AL2.0
https://github.com/vishnubob/wait-for-it/blob/master/wait-for-it.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kezhenxu94 commented on a change in pull request #5764: add wait-for-it.sh to start proxy after mysql instance available
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #5764:
URL: https://github.com/apache/shardingsphere/pull/5764#discussion_r429511784
##########
File path: shardingsphere-integration-test/shardingsphere-proxy-docker-build/src/main/resources/tool/wait-for-it.sh
##########
@@ -0,0 +1,195 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Use this script to test if a given TCP host/port are available
+
+WAITFORIT_cmdname=${0##*/}
+
+echoerr() { if [[ $WAITFORIT_QUIET -ne 1 ]]; then echo "$@" 1>&2; fi }
+
+usage()
+{
+ cat << USAGE >&2
Review comment:
FYI @tristaZero
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org