[GitHub] [spark] rangadi commented on a diff in pull request #41039: [SPARK-43360][SS][CONNECT] Scala client StreamingQueryManager

["rangadi (via GitHub)" <gi...@apache.org>]

rangadi commented on code in PR #41039:
URL: https://github.com/apache/spark/pull/41039#discussion_r1190357553


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala:
##########
@@ -297,4 +298,15 @@ object RemoteStreamingQuery {
       name = if (result.getName.isEmpty) null else result.getName,
       sparkSession = sparkSession)
   }
+
+  def fromStreamingQueryInstanceResponse(
+      sparkSession: SparkSession,
+      q: StreamingQueryInstance): RemoteStreamingQuery = {
+
+    new RemoteStreamingQuery(
+      UUID.fromString(q.getId.getId),
+      UUID.fromString(q.getId.getRunId),
+      q.getName,

Review Comment:
   Should this be null if name is not set? I don't think empty string is correct. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org