You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/10/24 18:49:44 UTC
[jira] Created: (HADOOP-4516) Counter formatting for the user logs
should be pulled out of the public Counters API
Counter formatting for the user logs should be pulled out of the public Counters API
------------------------------------------------------------------------------------
Key: HADOOP-4516
URL: https://issues.apache.org/jira/browse/HADOOP-4516
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Owen O'Malley
Fix For: 0.20.0
Currently the mapred.Counters class includes an obsolete format (makeCompactString) and a format that is only used by the user logs (makeEscapeCompactString). makeCompactString should be deprecated and later removed.The makeEscapeCompactString should be refactored to a non-public class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4516) Counter formatting for the user
logs should be pulled out of the public Counters API
Posted by "Suhas Gogate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689754#action_12689754 ]
Suhas Gogate commented on HADOOP-4516:
--------------------------------------
adding the requirement here to make the fromEscapedCompactString() API available. It is deprecated in 0.20. Hadoop vaidya contrib project uses it to parse the counter string from job history. (See HADOOP-5582 for more details. It is marked duplicate of this issue.).
> Counter formatting for the user logs should be pulled out of the public Counters API
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-4516
> URL: https://issues.apache.org/jira/browse/HADOOP-4516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Fix For: 0.20.0
>
>
> Currently the mapred.Counters class includes an obsolete format (makeCompactString) and a format that is only used by the user logs (makeEscapeCompactString). makeCompactString should be deprecated and later removed.The makeEscapeCompactString should be refactored to a non-public class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4516) Counter formatting for the user
logs should be pulled out of the public Counters API
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642955#action_12642955 ]
Owen O'Malley commented on HADOOP-4516:
---------------------------------------
The escaped compact format is only used for the log files. If there is another use, then we can make it public. In the mean time it just makes the public interface bigger and more confusing for users.
However, it goes deeper than that. In particular, embedding various output formats in the Counters -> Groups -> Counters classes isn't necessary or good. It is better to have the different encodings in different classes that use the standard apis.
> Counter formatting for the user logs should be pulled out of the public Counters API
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-4516
> URL: https://issues.apache.org/jira/browse/HADOOP-4516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Fix For: 0.20.0
>
>
> Currently the mapred.Counters class includes an obsolete format (makeCompactString) and a format that is only used by the user logs (makeEscapeCompactString). makeCompactString should be deprecated and later removed.The makeEscapeCompactString should be refactored to a non-public class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4516) Counter formatting for the user
logs should be pulled out of the public Counters API
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642621#action_12642621 ]
Amar Kamat commented on HADOOP-4516:
------------------------------------
bq. makeCompactString should be deprecated
+1
bq. The makeEscapeCompactString should be refactored to a non-public class.
What will be reason for doing so? There might a user code that might need to stringify a local counter to write it to a file. The api to de-stringify can be used by the applications that process job logs externally and want to reconstruct the counter.
> Counter formatting for the user logs should be pulled out of the public Counters API
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-4516
> URL: https://issues.apache.org/jira/browse/HADOOP-4516
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Fix For: 0.20.0
>
>
> Currently the mapred.Counters class includes an obsolete format (makeCompactString) and a format that is only used by the user logs (makeEscapeCompactString). makeCompactString should be deprecated and later removed.The makeEscapeCompactString should be refactored to a non-public class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.