You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/07/29 06:34:33 UTC
Review Request 50598: ATLAS-1066: fix for failure in Falcon hook while
posting to kafka
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50598/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1066
https://issues.apache.org/jira/browse/ATLAS-1066
Repository: atlas
Description
-------
The hook implmentation object was directly registered with Falcon to receive notifications, instead of registering the shim object. This resulted in the failure during callback while looking for classes in plugin classloader.
Diffs
-----
addons/falcon-bridge-shim/src/main/java/org/apache/atlas/falcon/service/AtlasService.java a5dd400
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 0acd964
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java 889317e
Diff: https://reviews.apache.org/r/50598/diff/
Testing
-------
Verified that Falcon hooks successfully post notifications to Kafka with this fix.
Thanks,
Madhan Neethiraj
Re: Review Request 50598: ATLAS-1066: fix for failure in Falcon hook
while posting to kafka
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50598/#review144062
-----------------------------------------------------------
Ship it!
Ship It!
- Shwetha GS
On July 29, 2016, 6:34 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50598/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 6:34 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1066
> https://issues.apache.org/jira/browse/ATLAS-1066
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The hook implmentation object was directly registered with Falcon to receive notifications, instead of registering the shim object. This resulted in the failure during callback while looking for classes in plugin classloader.
>
>
> Diffs
> -----
>
> addons/falcon-bridge-shim/src/main/java/org/apache/atlas/falcon/service/AtlasService.java a5dd400
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 0acd964
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java 889317e
>
> Diff: https://reviews.apache.org/r/50598/diff/
>
>
> Testing
> -------
>
> Verified that Falcon hooks successfully post notifications to Kafka with this fix.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>