[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3620: ARTEMIS-3343 throw exception on duplicate address-setting match

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #3620:
URL: https://github.com/apache/activemq-artemis/pull/3620#discussion_r663556203



##########
File path: artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java
##########
@@ -95,6 +95,22 @@ public void testDuplicateQueue() throws Exception {
       assertEquals(0, server.locateQueue(SimpleString.toSimpleString("q")).getMaxConsumers());
    }
 
+   @Test
+   public void testDuplicateAddressSettings() throws Exception {
+      String filename = "FileConfigurationParser-duplicateAddressSettings.xml";
+      FileConfiguration fc = new FileConfiguration();
+      FileDeploymentManager deploymentManager = new FileDeploymentManager(filename);
+      deploymentManager.addDeployable(fc);
+      try {
+         deploymentManager.readConfiguration();

Review comment:
       @clebertsuconic, I've updated the code to just log a WARN and ignore the settings from the duplicate match.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org