You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/06 01:03:27 UTC
[kudu-CR] Update partition syntax for single value range partitions
Hello Jean-Daniel Cryans, Matthew Jacobs, Dimitris Tsirogiannis,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5368
to review the following change.
Change subject: Update partition syntax for single value range partitions
......................................................................
Update partition syntax for single value range partitions
Impala is going to use the singular form of 'value' for single-valued
range partitions.
Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/common/partition.cc
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5368/1
--
To view, visit http://gerrit.cloudera.org:8080/5368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[kudu-CR] Update partition syntax for single value range partitions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Update partition syntax for single value range partitions
......................................................................
Update partition syntax for single value range partitions
Impala is going to use the singular form of 'value' for single-valued
range partitions.
Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
Reviewed-on: http://gerrit.cloudera.org:8080/5368
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/common/partition.cc
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[kudu-CR] Update partition syntax for single value range partitions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Update partition syntax for single value range partitions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628a4ca81456ca22519e8b7cc5e176a7362a2669
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No