[GitHub] [ozone] hemantk-12 commented on a diff in pull request #5303: HDDS-7601. Added new columnFamily: compactionLogTable to store compaction entries

["hemantk-12 (via GitHub)" <gi...@apache.org>]

hemantk-12 commented on code in PR #5303:
URL: https://github.com/apache/ozone/pull/5303#discussion_r1327871803


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -479,4 +479,19 @@ message DeletedBlocksTransactionInfo {
     optional int64 containerID = 2;
     repeated int64 localID = 3;
     optional int32 count = 4;
-}
\ No newline at end of file
+}
+

Review Comment:
   Technically `startKey`, `endKey` and `columnFamily` are required but there are optional to make it backward compatible.
   
   What is the benefit of creating separate proto message `FileInfoRange`? What's your rational behind it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org