You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "ryankert01 (via GitHub)" <gi...@apache.org> on 2026/01/19 10:07:50 UTC
[PR] Libtorch integration with pre-commit hook [mahout]
ryankert01 opened a new pull request, #873:
URL: https://github.com/apache/mahout/pull/873
### Purpose of PR
<!-- Describe what this PR does. -->
### Related Issues or PRs
<!-- Add links to related issues or PRs. -->
<!-- - Closes #123 -->
<!-- - Related to #123 -->
### Changes Made
<!-- Please mark one with an "x" -->
- [ ] Bug fix
- [ ] New feature
- [ ] Refactoring
- [ ] Documentation
- [ ] Test
- [ ] CI/CD pipeline
- [ ] Other
### Breaking Changes
<!-- Does this PR introduce a breaking change? -->
- [ ] Yes
- [ ] No
### Checklist
<!-- Please mark each item with an "x" when complete -->
<!-- If not all items are complete, please open this as a **Draft PR**.
Once all requirements are met, mark as ready for review. -->
- [ ] Added or updated unit tests for all changes
- [ ] Added or updated documentation for all changes
- [ ] Successfully built and ran all unit tests or manual tests locally
- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
- [ ] Code follows ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Libtorch integration [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #873:
URL: https://github.com/apache/mahout/pull/873#discussion_r2704305589
##########
.pre-commit-config.yaml:
##########
@@ -65,13 +65,18 @@ repos:
- id: fmt
pass_filenames: false
args: ['--manifest-path', 'qdp/Cargo.toml', '--all']
- - id: clippy
- # clippy needs context of the whole crate to compile correctly
+ - repo: local
+ hooks:
+ - id: cargo-clippy
Review Comment:
nit: should we continue to use `clippy` only here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Libtorch integration [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #873:
URL: https://github.com/apache/mahout/pull/873#discussion_r2704305589
##########
.pre-commit-config.yaml:
##########
@@ -65,13 +65,18 @@ repos:
- id: fmt
pass_filenames: false
args: ['--manifest-path', 'qdp/Cargo.toml', '--all']
- - id: clippy
- # clippy needs context of the whole crate to compile correctly
+ - repo: local
+ hooks:
+ - id: cargo-clippy
Review Comment:
nit: should we continue to use `clippy` only for id here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update to use local command for clippy cehck [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #873:
URL: https://github.com/apache/mahout/pull/873#issuecomment-3767820214
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update to use local command for clippy check [mahout]
Posted by "ryankert01 (via GitHub)" <gi...@apache.org>.
ryankert01 merged PR #873:
URL: https://github.com/apache/mahout/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org