[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #492: [Test] Cleanup tests with Files#createTempDir()

[GitBox <gi...@apache.org>]

kaijchen commented on code in PR #492:
URL: https://github.com/apache/incubator-uniffle/pull/492#discussion_r1071226867


##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -146,36 +153,14 @@ public static void cleanCluster() throws Exception {
     coordinators = Lists.newArrayList();
   }
 
-  @BeforeEach
-  public void initEnv() throws Exception {
-    // spark.rss.data.replica=3
-    // spark.rss.data.replica.write=2
-    // spark.rss.data.replica.read=2
-    ((ShuffleServerGrpcClient)ShuffleServerClientFactory
-      .getInstance().getShuffleServerClient("GRPC", shuffleServerInfo0)).adjustTimeout(200);
-    ((ShuffleServerGrpcClient)ShuffleServerClientFactory
-      .getInstance().getShuffleServerClient("GRPC", shuffleServerInfo1)).adjustTimeout(200);
-    ((ShuffleServerGrpcClient)ShuffleServerClientFactory
-      .getInstance().getShuffleServerClient("GRPC", shuffleServerInfo2)).adjustTimeout(200);
-  }
-
   @AfterEach
   public void cleanEnv() throws Exception {
     if (shuffleWriteClientImpl != null) {
       shuffleWriteClientImpl.close();
     }
     cleanCluster();
-    initCluster();
-    // we need recovery `rpcTime`, or some unit tests may fail
-    ((ShuffleServerGrpcClient)ShuffleServerClientFactory

Review Comment:
   Immediately after the `@AfterEach`, the `@BeforeEach initEnv()` is executed, which overwrites those values.
   However, I agree it's probably better to change this in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org