[jira] [Commented] (LUCENE-6900) Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013006#comment-15013006 ] 

Martijn van Groningen commented on LUCENE-6900:
-----------------------------------------------

No there isn't, what I remember is that when creating this class it was common to use 'null' as an indication to sort by relevancy.

> Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-6900
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6900
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/grouping
>            Reporter: David Smiley
>            Priority: Minor
>
> In AbstractSecondPassGroupingCollector, {{withinGroupSort}} uses a value of null to indicate a relevance sort.  I think it's nicer to use Sort.RELEVANCE for this -- after all it's how the {{groupSort}} variable is handled.  This choice is also seen in GroupingSearch; likely some other collaborators too.
> [~martijn.v.groningen] is there some wisdom in the current choice that escapes me?  If not I'll post a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org