You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Eric Fung (JIRA)" <ji...@apache.org> on 2012/07/19 13:46:35 UTC

[jira] [Created] (HTTPCLIENT-1217) AutoRetryHttpClient does not release connection on retries

Eric Fung created HTTPCLIENT-1217:
-------------------------------------

             Summary: AutoRetryHttpClient does not release connection on retries
                 Key: HTTPCLIENT-1217
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1217
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 4.2 Final
            Reporter: Eric Fung


In this method of AutoRetryHttpClient:

execute(HttpHost target, HttpRequest request, HttpContext context)

the backend creates a new HttpResponse object on each retry attempt, but 
the response entity is not consumed, leading to connections that are never closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPCLIENT-1217) AutoRetryHttpClient does not release connection on retries

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-1217:
------------------------------------------

    Affects Version/s:     (was: 4.2 Final)
                       4.2.1
        Fix Version/s: 4.2.2
    
> AutoRetryHttpClient does not release connection on retries
> ----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1217
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1217
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Eric Fung
>             Fix For: 4.2.2
>
>
> In this method of AutoRetryHttpClient:
> execute(HttpHost target, HttpRequest request, HttpContext context)
> the backend creates a new HttpResponse object on each retry attempt, but 
> the response entity is not consumed, leading to connections that are never closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1217) AutoRetryHttpClient does not release connection on retries

Posted by "Alin Vasile (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418552#comment-13418552 ] 

Alin Vasile commented on HTTPCLIENT-1217:
-----------------------------------------

Is this bug related to HTTPCORE-302?
                
> AutoRetryHttpClient does not release connection on retries
> ----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1217
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1217
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Eric Fung
>             Fix For: 4.2.2
>
>
> In this method of AutoRetryHttpClient:
> execute(HttpHost target, HttpRequest request, HttpContext context)
> the backend creates a new HttpResponse object on each retry attempt, but 
> the response entity is not consumed, leading to connections that are never closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Resolved] (HTTPCLIENT-1217) AutoRetryHttpClient does not release connection on retries

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1217.
-------------------------------------------

    Resolution: Fixed

Fix committed to SVN trunk and 4.2.x branch.

@Eric: Please review / re-test

@Alin: I do not think so. The class simply made no attempt to release connection at all when request is retried. The code in question was contributed by an external contributor and I made a lousy job reviewing it.

Oleg 

                
> AutoRetryHttpClient does not release connection on retries
> ----------------------------------------------------------
>
>                 Key: HTTPCLIENT-1217
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1217
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.2.1
>            Reporter: Eric Fung
>             Fix For: 4.2.2
>
>
> In this method of AutoRetryHttpClient:
> execute(HttpHost target, HttpRequest request, HttpContext context)
> the backend creates a new HttpResponse object on each retry attempt, but 
> the response entity is not consumed, leading to connections that are never closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org