You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2018/08/11 20:00:28 UTC
[GitHub] Code0x58 commented on a change in pull request #2975: Docker Ubuntu
tweaks
Code0x58 commented on a change in pull request #2975: Docker Ubuntu tweaks
URL: https://github.com/apache/incubator-heron/pull/2975#discussion_r209436212
##########
File path: docker/scripts/build-base.sh
##########
@@ -75,7 +75,7 @@ case $# in
echo " "
echo "Usage: $0 <platform> <version_string> <output-directory>"
echo " "
- echo "Platforms Supported: debian8, ubuntu14.04, centos7"
+ echo "Platforms Supported: debian8, ubuntu14.04, ubuntu16.04, centos7"
Review comment:
fun fact: the [debian8 images](https://github.com/apache/incubator-heron/blob/0.17.8/docker/base/Dockerfile.base.debian8) aren't debian8 as they use `openjdk:8-jdk-slim` which has move on:
```
$ docker run --rm openjdk:8-jdk-slim cat /etc/debian_version
9.4
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services