[GitHub] [cloudstack] rhtyd edited a comment on pull request #5104: Localization: Hellenic (Greek) Translation

[GitBox <gi...@apache.org>]

rhtyd edited a comment on pull request #5104:
URL: https://github.com/apache/cloudstack/pull/5104#issuecomment-860858611


   Hi @fermosan I think the translation file needs improvement:
   - The translation is done via translation keys and not by English strings, for example see the German translation: https://github.com/apache/cloudstack/blob/main/ui/public/locales/de_DE.json
   - To translate you may copy and rename the https://github.com/apache/cloudstack/blob/main/ui/public/locales/en.json to locale specific file and then do the translation
   - (optional we can help you do this as well) Next you'll need to add your translation to the translation menu: https://github.com/apache/cloudstack/blob/main/ui/src/components/header/TranslationMenu.vue#L43
   - To get this in 4.15, please raise the PR against 4.15 branch (for that you may edit the base branch and rebase it against 4.15, or submit a new one by first checking out a branch from 4.15 branch and then when submitting the PR submit to the 4.15 branch)
   
   I'll cut RC2 by eod tomorrow (after 6PM IST) happy to include this if you can complete the translation by tomorrow. Otherwise we can include in future releases. Thanks for your submission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org