You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by dashorst <gi...@git.apache.org> on 2018/02/05 12:59:22 UTC

[GitHub] wicket pull request #265: WICKET-6528 Don't block user when component not on...

GitHub user dashorst opened a pull request:

    https://github.com/apache/wicket/pull/265

    WICKET-6528 Don't block user when component not on Page using AJAX

    Re-instate the behavior that was in versions < 8.0 that a component
    added to an AjaxRequestTarget but is not part of the page, would be
    ignored (or failed to refresh with an error in the JavaScript console).
    
    So instead of always throwing an error, we only do so in DEVELOPMENT
    mode causing an error page, and in DEPLOYMENT mode we only log the
    fault, but don't break the application hard for the user: the component
    refresh is ignored, just as it would've been in versions prior to 8.
    
    Fixes WICKET-6528

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/wicket WICKET-6528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit 60c94cd6927a2ec6962639ead96f57f127f954e5
Author: Martijn Dashorst <ma...@...>
Date:   2018-02-05T12:57:54Z

    Don't block user when component not on Page using AJAX
    
    Re-instate the behavior that was in versions < 8.0 that a component
    added to an AjaxRequestTarget but is not part of the page, would be
    ignored (or failed to refresh with an error in the JavaScript console).
    
    So instead of always throwing an error, we only do so in DEVELOPMENT
    mode causing an error page, and in DEPLOYMENT mode we only log the
    fault, but don't break the application hard for the user: the component
    refresh is ignored, just as it would've been in versions prior to 8.
    
    Fixes WICKET-6528

----


---

[GitHub] wicket pull request #265: WICKET-6528 Don't block user when component not on...

Posted by dashorst <gi...@git.apache.org>.

Github user dashorst closed the pull request at:

    https://github.com/apache/wicket/pull/265


---

[GitHub] wicket issue #265: WICKET-6528 Don't block user when component not on Page u...

Posted by dashorst <gi...@git.apache.org>.

Github user dashorst commented on the issue:

    https://github.com/apache/wicket/pull/265
  
    Is merged with commit https://github.com/apache/wicket/commit/3be55cf5a24982cfca400225aabb6c4296859a7d


---