[GitHub] [madlib] kaknikhil commented on a change in pull request #394: DL: Add model_arch column to model data table

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #394: DL: Add model_arch column to model data table
URL: https://github.com/apache/madlib/pull/394#discussion_r285816474
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -321,9 +321,10 @@ def fit(schema_madlib, source_table, model,model_arch_table,
                   description, aggregate_runtime, class_values])
 
     create_output_table = plpy.prepare("""
-        CREATE TABLE {0} AS
-        SELECT $1 as model_data""".format(model), ["bytea"])
-    plpy.execute(create_output_table, [model_state])
+        CREATE TABLE {0} AS SELECT
+        $1 as model_data,
+        $2 as {1}""".format(model, Format.MODEL_ARCH), ["bytea", "text"])
 
 Review comment:
   you are right it should be json. I will fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services