[GitHub] [ignite] skorotkov commented on a change in pull request #9754: IGNITE-16320 [ducktests] Do not override JVM options passed to IgniteApplicationService

[GitBox <gi...@apache.org>]

skorotkov commented on a change in pull request #9754:
URL: https://github.com/apache/ignite/pull/9754#discussion_r803396555



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -76,30 +76,50 @@ class IgniteSpec(metaclass=ABCMeta):
     This class is a basic Spec
     """
 
-    def __init__(self, service, jvm_opts, full_jvm_opts):
+    def __init__(self, service, jvm_opts=None, full_jvm_opts=None):

Review comment:
       OK for exception.  
   
   Not sure about the interpretation which is suggested for extra_jvm_opts vs. jvm_opts.
   
   Do you mean the following:
   
   *  _extra_jvm_opts_  are options to be **added** to default ones from the framework?
   *  _jvm_opts_  are options to be applied "as is" ignoring the defaults from framework completely?
   * Only one of two may be passed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org