You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "litiliu (via GitHub)" <gi...@apache.org> on 2026/08/07 07:15:57 UTC
[PR] [common] Add standard principal type constants [fluss]
litiliu opened a new pull request, #3891:
URL: https://github.com/apache/fluss/pull/3891
<!-- Generated-by: Codex following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md) -->
### Purpose
Related to #3829.
Provide canonical names for the standard User, Group, and Role principal types while preserving the string-based extensibility of `FlussPrincipal`.
### Brief change log
- Add `USER_TYPE`, `GROUP_TYPE`, and `ROLE_TYPE` constants to `FlussPrincipal`.
- Use `USER_TYPE` when creating the anonymous principal and authenticated SASL user principals.
- Keep the existing String constructor so custom principal types remain supported.
### Tests
- `./mvnw -pl fluss-common -DskipITs verify`
- 1,732 unit tests passed.
- 186 integration tests passed.
- Checkstyle and Spotless passed.
### API and Format
This adds public constants to `FlussPrincipal`. It does not change existing constructors, ACL matching semantics, configuration, RPC wire format, or storage format.
### Documentation
No documentation changes are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add standard principal type constants [fluss]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 commented on code in PR #3891:
URL: https://github.com/apache/fluss/pull/3891#discussion_r3746312473
##########
fluss-common/src/main/java/org/apache/fluss/security/acl/FlussPrincipal.java:
##########
@@ -41,7 +41,11 @@
*/
@PublicEvolving
public class FlussPrincipal implements Principal {
- public static final FlussPrincipal ANONYMOUS = new FlussPrincipal("ANONYMOUS", "User");
+ public static final String USER_TYPE = "User";
+ public static final String GROUP_TYPE = "Group";
Review Comment:
What's the group and role used in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add standard principal type constants [fluss]
Posted by "litiliu (via GitHub)" <gi...@apache.org>.
litiliu closed pull request #3891: [common] Add standard principal type constants
URL: https://github.com/apache/fluss/pull/3891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add standard principal type constants [fluss]
Posted by "litiliu (via GitHub)" <gi...@apache.org>.
litiliu commented on PR #3891:
URL: https://github.com/apache/fluss/pull/3891#issuecomment-5236333438
Closing this for now because GROUP_TYPE and ROLE_TYPE do not yet have a production consumer. These constants can be introduced together with the change that first consumes them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Add standard principal type constants [fluss]
Posted by "litiliu (via GitHub)" <gi...@apache.org>.
litiliu commented on PR #3891:
URL: https://github.com/apache/fluss/pull/3891#issuecomment-5215522811
@loserwang1024 please help to review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org