You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/18 18:51:24 UTC

[GitHub] [spark] avenherak commented on a change in pull request #27903: [SPARK-31149][PySpark] PySpark job not killing Spark Daemon processes…

avenherak commented on a change in pull request #27903: [SPARK-31149][PySpark] PySpark job not killing Spark Daemon processes…
URL: https://github.com/apache/spark/pull/27903#discussion_r394569235
 
 

 ##########
 File path: python/pyspark/daemon.py
 ##########
 @@ -100,7 +100,7 @@ def manager():
     def shutdown(code):
         signal.signal(SIGTERM, SIG_DFL)
         # Send SIGHUP to notify workers of shutdown
-        os.kill(0, SIGHUP)
+        os.kill(0, SIGTERM)
         sys.exit(code)
 
 Review comment:
   Before the fix:
   ps -ef|grep -i pyspark.daemon
   /apps/anaconda3-5.3.0/bin/python -m pyspark.daemon
   /apps/anaconda3-5.3.0/bin/python -m pyspark.daemon
   /apps/anaconda3-5.3.0/bin/python -m pyspark.daemon
   
   After the fix:
   ps -ef|grep -i pyspark.daemon

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org