You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/14 14:52:01 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #2255: Removed java.platform dependency from the Gradle Projects module
lkishalmi opened a new pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255
Well, this one shall fix the java.platform dependency issue for #2252. Unfortunately it means that the API compatibility is broken. Please review this and point at the weak spots!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#discussion_r454556566
##########
File path: extide/gradle/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
AutoUpdate-Show-In-Client: false
-OpenIDE-Module: org.netbeans.modules.gradle/2
Review comment:
Thanks! Great idea! I could return a <String, null> pair. That's supposed to be handled as a broken/invalid platform it would be sightly better than responding a straight null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#issuecomment-659165179
Thanks Laszlo for doing this! (I apologize for not commenting sooner - too much to do.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#issuecomment-659025826
Got an approval and a clean CI state before updating the apichanges.xml, merging it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#discussion_r455509797
##########
File path: extide/gradle/apichanges.xml
##########
@@ -83,6 +83,34 @@ is the proper place.
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="gradle-java-independence">
+ <api name="general"/>
+ <summary>Remove Java Platform dependency.</summary>
+ <version major="2" minor="3"/>
+ <date year="2020" month="7" day="15"/>
+ <author login="lkishalmi"/>
+ <compatibility binary="compatible" source="compatible"/>
+ <description>
+ <p>
+ Due to recent movement and the plan to support Gradle native
+ projects as well in the future the dependency on
+ Java Platform module has been removed.
+ </p>
+ <p>
+ The removal affects <code>org.netbeans.modules.gradle.api.execute.RunUtils</code>
Review comment:
Btw. it is possible to use `<a href="@TOP@/org/netbeans/modules/gradle/api/execute/RunUtills.html">RunUtils</a>` to connect to the Javadoc generated classes.
##########
File path: extide/gradle/nbproject/org-netbeans-modules-gradle.sig
##########
@@ -480,8 +480,8 @@ meth public static org.netbeans.modules.gradle.spi.actions.ReplaceTokenProvider
meth public static org.openide.execution.ExecutorTask executeGradle(org.netbeans.modules.gradle.api.execute.RunConfig,java.lang.String)
meth public static org.openide.filesystems.FileObject extractFileObjectfromLookup(org.openide.util.Lookup)
meth public static org.openide.filesystems.FileObject[] extractFileObjectsfromLookup(org.openide.util.Lookup)
-meth public static org.openide.util.Pair<java.lang.String,org.netbeans.api.java.platform.JavaPlatform> getActivePlatform(java.lang.String)
-meth public static org.openide.util.Pair<java.lang.String,org.netbeans.api.java.platform.JavaPlatform> getActivePlatform(org.netbeans.api.project.Project)
+meth public static org.openide.util.Pair getActivePlatform(java.lang.String)
Review comment:
Great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#discussion_r455511869
##########
File path: extide/gradle/apichanges.xml
##########
@@ -83,6 +83,34 @@ is the proper place.
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="gradle-java-independence">
+ <api name="general"/>
+ <summary>Remove Java Platform dependency.</summary>
+ <version major="2" minor="3"/>
+ <date year="2020" month="7" day="15"/>
+ <author login="lkishalmi"/>
+ <compatibility binary="compatible" source="compatible"/>
+ <description>
+ <p>
+ Due to recent movement and the plan to support Gradle native
+ projects as well in the future the dependency on
+ Java Platform module has been removed.
+ </p>
+ <p>
+ The removal affects <code>org.netbeans.modules.gradle.api.execute.RunUtils</code>
Review comment:
Thanks! I'm going to try to keep that in mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2255: Removed java.platform dependency from the Gradle Projects module
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#discussion_r454486647
##########
File path: extide/gradle/nbproject/project.xml
##########
@@ -139,15 +139,6 @@
<specification-version>1.41.1</specification-version>
</run-dependency>
</dependency>
- <dependency>
Review comment:
OK.
##########
File path: extide/gradle/nbproject/org-netbeans-modules-gradle.sig
##########
@@ -1,1074 +0,0 @@
-#Signature file v4.1
-#Version 2.0
-
Review comment:
I don't think you want to completely remove the file. You may want to remove just the lines that are no longer present.
##########
File path: extide/gradle/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
AutoUpdate-Show-In-Client: false
-OpenIDE-Module: org.netbeans.modules.gradle/2
Review comment:
I suggest to keep the removed methods around, just deprecated. Then you don't have to increment the release version and you can stick with `/2`.
Btw. the methods could even delegate to some provider to work the same way that did so far...
##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/RunUtils.java
##########
@@ -347,41 +337,6 @@ public static ReplaceTokenProvider simpleReplaceTokenProvider(final String token
};
}
- /**
- * Returns the active platform used by the project or null if the active
- * project platform is broken.
- * @param activePlatformId the name of platform used by Ant script or null
- * for default platform.
- * @return active {@link JavaPlatform} or null if the project's platform
- * is broken
- */
- public static Pair<String, JavaPlatform> getActivePlatform(final String activePlatformId) {
Review comment:
You can keep these two methods around, just `@deprecated`. Change the return type to `Pair` - e.g. the raw type. JVM is going to link to these two methods without a problem. See more in my [erasure](http://wiki.apidesign.org/wiki/Erasure) blog post.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists