You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/04 16:04:24 UTC

[GitHub] [fineract] BLasan commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI

BLasan commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961187492


   > Yes. Ideally Fineract would respect the tenant tile zones configured in the database, and then the server time zone would not matter. However this is not working 100%. Consequently a number of the integration tests fail intermittently if the server time zone is not the same as the tenant time zone. As our integration tests use tenant time zone as Asia/Kolkata, we need to set the server timezone to be the same to avoid "flakiness" of tests If you look in the Travis CI script you can see the same setting hardcoded there.
   > […](#)
   > On Thu, Nov 4, 2021, 23:11 Benura Abeywardena ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/build.yml <[#1955 (comment)](https://github.com/apache/fineract/pull/1955#discussion_r742933283)>: > @@ -0,0 +1,38 @@ +name: Fineract Gradle build +on: [push] + +jobs: + build: + runs-on: ubuntu-latest + env: + TZ: Asia/Kolkata Any specific reason to select TZ as Asia/Kolkata ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <[#1955 (review)](https://github.com/apache/fineract/pull/1955#pullrequestreview-797876295)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCXQYUBG2AVA3X6HE4TUKKPDPANCNFSM5HLTWCBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=
 utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   
   Thanks !!! Looks good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org