You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/02 17:11:16 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
nsivabalan opened a new pull request #4194:
URL: https://github.com/apache/hudi/pull/4194
## What is the purpose of the pull request
`hoodie.populate.meta.fields` is used to enable or disable virtual keys. Looks like with HfileWriters we don't honor this config. Fixing it in this patch.
## Brief change log
- Fixing HoodieHFile writers to honor populate meta fields config.
## Verify this pull request
This change added tests and can be verified as follows:
- Added/fixed tests in TestHoodieHFileReaderWriter
- TestHoodieBackedMetadata.testVirtualKeysInBaseFiles
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985195599
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
}, {
"hash" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978",
"triggerID" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
* 329268998187ca1ce64017ab8c2eb98eb9465784 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985139158
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984828763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984828763
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985158247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761504401
##########
File path: hudi-client/hudi-client-common/src/test/resources/exampleSchemaWithMetaFields.avsc
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "example.schema",
+ "type": "record",
+ "name": "trip",
+ "fields": [
+ {
+ "name": "_hoodie_commit_time",
Review comment:
test is just for tests. should be fine I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984831133
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761333253
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileWriter.java
##########
@@ -104,9 +106,13 @@ public HoodieHFileWriter(String instantTime, Path file, HoodieHFileConfig hfileC
@Override
public void writeAvroWithMetadata(R avroRecord, HoodieRecord record) throws IOException {
- prepRecordWithMetadata(avroRecord, record, instantTime,
- taskContextSupplier.getPartitionIdSupplier().get(), recordIndex, file.getName());
- writeAvro(record.getRecordKey(), (IndexedRecord) avroRecord);
+ if (populateMetaFields) {
Review comment:
Is this change backward compatible. On disk format of metadata records are now going to miss out on the meta fields. After the downgrade would this break anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984870007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985139158
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985180792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985195599
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
}, {
"hash" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978",
"triggerID" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
* 329268998187ca1ce64017ab8c2eb98eb9465784 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4194:
URL: https://github.com/apache/hudi/pull/4194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984870007
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761768414
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
##########
@@ -346,6 +363,56 @@ public void testMetadataTableServices() throws Exception {
assertEquals(tableMetadata.getLatestCompactionTime().get(), "0000004001");
}
+
+ /**
+ * Tests that virtual key configs are honored in base files after compaction in metadata table.
+ *
+ * @throws Exception
+ */
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testVirtualKeysInBaseFiles(boolean populateMetaFields) throws Exception {
+ HoodieTableType tableType = MERGE_ON_READ;
+ init(tableType, false);
+ writeConfig = getWriteConfigBuilder(true, true, false)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder()
+ .enable(true)
+ .enableFullScan(true)
+ .enableMetrics(false)
+ .withPopulateMetaFields(populateMetaFields)
+ .withMaxNumDeltaCommitsBeforeCompaction(2)
+ .build()).build();
+ initWriteConfigAndMetatableWriter(writeConfig, true);
+
+ doWriteOperation(testTable, "0000001", INSERT);
+ doClean(testTable, "0000003", Arrays.asList("0000001"));
+ // this should have triggered compaction in metadata table
+ doWriteOperation(testTable, "0000004", UPSERT);
+
+ HoodieTableMetadata tableMetadata = metadata(writeConfig, context);
+ assertTrue(tableMetadata.getLatestCompactionTime().isPresent());
+ assertEquals(tableMetadata.getLatestCompactionTime().get(), "0000004001");
+
+ HoodieTableMetaClient metadataMetaClient = HoodieTableMetaClient.builder().setConf(hadoopConf).setBasePath(metadataTableBasePath).build();
+ HoodieWriteConfig metadataTableWriteConfig = getMetadataWriteConfig(writeConfig);
+ metadataMetaClient.reloadActiveTimeline();
+
+ HoodieTable table = HoodieSparkTable.create(metadataTableWriteConfig, context, metadataMetaClient);
+ table.getHoodieView().sync();
+ List<FileSlice> fileSlices = table.getSliceView().getLatestFileSlices("files").collect(Collectors.toList());
+ HoodieBaseFile baseFile = fileSlices.get(0).getBaseFile().get();
+ HoodieHFileReader hoodieHFileReader = new HoodieHFileReader(context.getHadoopConf().get(), new Path(baseFile.getPath()),
+ new CacheConfig(context.getHadoopConf().get()));
+ List<Pair<String, IndexedRecord>> records = hoodieHFileReader.readAllRecords();
Review comment:
good test
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieMetadataBase.java
##########
@@ -292,7 +292,7 @@ protected HoodieWriteConfig getWriteConfig(boolean autoCommit, boolean useFileLi
.enable(useFileListingMetadata)
.enableFullScan(enableFullScan)
.enableMetrics(enableMetrics)
- .withPopulateMetaFields(false)
+ .withPopulateMetaFields(HoodieMetadataConfig.POPULATE_META_FIELDS.defaultValue())
Review comment:
maybe we should remove this line.. as we are just setting the default here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985194792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
}, {
"hash" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
* 329268998187ca1ce64017ab8c2eb98eb9465784 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985180792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985215090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
}, {
"hash" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978",
"triggerID" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 329268998187ca1ce64017ab8c2eb98eb9465784 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761888049
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieMetadataBase.java
##########
@@ -292,7 +292,7 @@ protected HoodieWriteConfig getWriteConfig(boolean autoCommit, boolean useFileLi
.enable(useFileListingMetadata)
.enableFullScan(enableFullScan)
.enableMetrics(enableMetrics)
- .withPopulateMetaFields(false)
+ .withPopulateMetaFields(HoodieMetadataConfig.POPULATE_META_FIELDS.defaultValue())
Review comment:
guess it should be fine. I will go ahead and land this. can take this up in some other future PR. Don't want to drag the release blocker PR. wanted to get it landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985118388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985117106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
* cae07a318563c1acfc5ae1e46d540aa14205941a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985158247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985157116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985194792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
}, {
"hash" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "329268998187ca1ce64017ab8c2eb98eb9465784",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3973)
* 329268998187ca1ce64017ab8c2eb98eb9465784 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-984831133
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] manojpec commented on a change in pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
manojpec commented on a change in pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#discussion_r761337249
##########
File path: hudi-client/hudi-client-common/src/test/resources/exampleSchemaWithMetaFields.avsc
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+{
+ "namespace": "example.schema",
+ "type": "record",
+ "name": "trip",
+ "fields": [
+ {
+ "name": "_hoodie_commit_time",
Review comment:
0.90 release expects these meta fields to be a simple type and not union with possible null values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985157116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
}, {
"hash" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5fe7dbee3ef83538166f2c3a0b9e687f22877e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
* f5fe7dbee3ef83538166f2c3a0b9e687f22877e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985118388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
* cae07a318563c1acfc5ae1e46d540aa14205941a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3967)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4194: [HUDI-2902] Fixing populate meta fields with Hfile writers
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4194:
URL: https://github.com/apache/hudi/pull/4194#issuecomment-985117106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956",
"triggerID" : "956f4afdb6ce24e869d521c14691a3423756a9ec",
"triggerType" : "PUSH"
}, {
"hash" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cae07a318563c1acfc5ae1e46d540aa14205941a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 956f4afdb6ce24e869d521c14691a3423756a9ec Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3956)
* cae07a318563c1acfc5ae1e46d540aa14205941a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org