You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2015/05/07 21:24:00 UTC

[jira] [Commented] (TAJO-1422) Investigate the case where fragments == null in SeqScanExec

    [ https://issues.apache.org/jira/browse/TAJO-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533241#comment-14533241 ] 

Hyunsik Choi commented on TAJO-1422:
------------------------------------

Thanks for your investigation. I'll close this issue as fixed, and then I'll make another jira in order to make this code better.

> Investigate the case where fragments == null in SeqScanExec
> -----------------------------------------------------------
>
>                 Key: TAJO-1422
>                 URL: https://issues.apache.org/jira/browse/TAJO-1422
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> See the following part in SeqScanExec. Intuitively, we don't need to make and execute Task if fragments is null. But, the current code requires null check. We need to investigate its essential cause, and we should remove this case if possible.
> {code:title=SeqScanExec.java}
>     if (fragments != null) {
>       if (fragments.length > 1) {
>         this.scanner = new MergeScanner(context.getConf(), plan.getPhysicalSchema(), meta,
>             FragmentConvertor.convert(context.getConf(), fragments), projected
>         );
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)