You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 18:39:49 UTC

[GitHub] [arrow-datafusion] thinkharderdev opened a new pull request, #2234: Add ExecutorMetricsCollector interface

thinkharderdev opened a new pull request, #2234:
URL: https://github.com/apache/arrow-datafusion/pull/2234

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2204 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Currently there is no way of getting execution metrics from Ballista executors (aside from parsing log messages). This adds a trait `ExecutorMetricsCollector` which can record stage execution metrics. Currently it just defaults to `LoggingMetricsCollector` which just logs the plan (same as before). 
   
   I'm also working on a prometheus metrics collector which we can upstream (under a feature flag) when it's ready. 
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   1. Add `ExecutorMetricsCollector` trait 
   2. Created default `LoggingMetricsCollector` implementation
   3. `Executor` needs to own an `Arc<dyn ExecutorMetricsCollector>` and call `record_stage` after executing a shuffle write. 
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #2234: Add ExecutorMetricsCollector interface

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2234:
URL: https://github.com/apache/arrow-datafusion/pull/2234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org