You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/11/20 12:32:47 UTC
[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1388
[FLINK-3052] [optimizer] Fix instantiation of bulk iteration candidates
When a candidate for a bulk iteration is instantiated, then the optimizer creates candidates
for the step function. It is then checked that there exists a candidate solution for the step
function whose properties met the properties of the input to the bulk iteration. Sometimes
it is necessary to add a no-op plan node to the end of the step function to generate the
correct properties. These new candidates have to be added to the final set of the accepted
candidates.
This commit adds that these new candidates are properly added to the set of accepted candidates.
Fix test and add new iteration tests
Add predecessor operator and dynamic path information to no op operator in bulk iterations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixBulkIteration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1388
----
commit 27e2085da7423bbb114ece8b9a0f19339c41a696
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-11-19T13:24:15Z
[FLINK-3052] [optimizer] Fix instantiation of bulk iteration candidates
When a candidate for a bulk iteration is instantiated, then the optimizer creates candidates
for the step function. It is then checked that there exists a candidate solution for the step
function whose properties met the properties of the input to the bulk iteration. Sometimes
it is necessary to add a no-op plan node to the end of the step function to generate the
correct properties. These new candidates have to be added to the final set of the accepted
candidates.
This commit adds that these new candidates are properly added to the set of accepted candidates.
Fix test and add new iteration tests
Add predecessor operator and dynamic path information to no op operator in bulk iterations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1388#issuecomment-158373108
Good fix!
+1 to merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1388#issuecomment-158391064
Will merge once Travis has passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---