You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by cschneider <gi...@git.apache.org> on 2016/11/21 14:55:40 UTC
[GitHub] incubator-tamaya pull request #8: Use bnd-maven-plugin. Minimize required co...
GitHub user cschneider opened a pull request:
https://github.com/apache/incubator-tamaya/pull/8
Use bnd-maven-plugin. Minimize required config
The current OSGi config is quite verbose and relies on packaging bundle.
In this PR I switch to using the bnd-maven-plugin and try to minimize the required config.
The needed settings per bundle are defined in bnd.bnd files which have a simple syntax. Bndtools also provides a nice editor for these files but it is not required.
Apart from that the individual projects then need no special setup in the pom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cschneider/incubator-tamaya osgi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit e414ba9b08947ef60fe4b087b67b11027175fe56
Author: Christian Schneider <ch...@die-schneider.net>
Date: 2016-11-21T14:52:14Z
Use bnd-maven-plugin. Minimize required config
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
LGTM. Can you create a JIRA ticket for this and add it to the commit message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by ottlinger <gi...@git.apache.org>.
Github user ottlinger commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
I've filed https://issues.apache.org/jira/browse/INFRA-13565 to properly integrate it within the ASF infrastructure and be able to close the PR - @cschneider thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin.
Minimize required config
Posted by "P. Ottlinger" <po...@apache.org>.
Hi all,
Am 22.02.2017 um 18:38 schrieb keilw:
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
in order to properly close/handle PRs I've created an INFRA ticket to
allow integration with github for all our projects:
https://issues.apache.org/jira/browse/INFRA-13565
Cheers,
Phil
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by keilw <gi...@git.apache.org>.
Github user keilw commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
So can this be closed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
@atsticks to close a PR, don't forget to include "This closes #8" in the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya pull request #8: Use bnd-maven-plugin. Minimize required co...
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider closed the pull request at:
https://github.com/apache/incubator-tamaya/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by atsticks <gi...@git.apache.org>.
Github user atsticks commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
Hi Christian
I applied the patch to the repo.
J Anatole
2016-11-21 15:55 GMT+01:00 Christian Schneider <no...@github.com>:
> The current OSGi config is quite verbose and relies on packaging bundle.
> In this PR I switch to using the bnd-maven-plugin and try to minimize the
> required config.
>
> The needed settings per bundle are defined in bnd.bnd files which have a
> simple syntax. Bndtools also provides a nice editor for these files but it
> is not required.
> Apart from that the individual projects then need no special setup in the
> pom.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/incubator-tamaya/pull/8
> Commit Summary
>
> - Use bnd-maven-plugin. Minimize required config
>
> File Changes
>
> - *A* code/api/bnd.bnd
> <https://github.com/apache/incubator-tamaya/pull/8/files#diff-0> (3)
> - *M* code/api/pom.xml
> <https://github.com/apache/incubator-tamaya/pull/8/files#diff-1> (34)
> - *A* code/core/bnd.bnd
> <https://github.com/apache/incubator-tamaya/pull/8/files#diff-2> (5)
> - *M* code/core/pom.xml
> <https://github.com/apache/incubator-tamaya/pull/8/files#diff-3> (32)
> - *M* pom.xml
> <https://github.com/apache/incubator-tamaya/pull/8/files#diff-4> (52)
>
> Patch Links:
>
> - https://github.com/apache/incubator-tamaya/pull/8.patch
> - https://github.com/apache/incubator-tamaya/pull/8.diff
>
> \u2014
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-tamaya/pull/8>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AC5sc__-zmHTdPQ0nNFjJ4gykjynYpLmks5rAbDpgaJpZM4K4Sub>
> .
>
--
*Anatole Tresch*
PPMC Member Apache Tamaya
JCP Star Spec Lead
*Switzerland, Europe Zurich, GMT+1*
*maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> *
*Twitter: @atsticks, @tamayaconf*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tamaya issue #8: Use bnd-maven-plugin. Minimize required config
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the issue:
https://github.com/apache/incubator-tamaya/pull/8
Thanks for applying the patch. I will close the PR. Btw. If you do git merge with the PR branch then the PR is closed automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---