You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/03/04 17:46:36 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5576: Installed some internal generics to fix some compiler warnings
tbw777 opened a new pull request, #5576:
URL: https://github.com/apache/netbeans/pull/5576
Only private simple non generic collections was refactored to generics if no out of class usage detected.
#5524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1763348339
@mbien
@BradWalker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro closed pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro closed pull request #5576: Installed some internal generics to fix some compiler warnings
URL: https://github.com/apache/netbeans/pull/5576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on code in PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#discussion_r1383273215
##########
ide/editor/demosrc/base/org/netbeans/editor/example/Editor.java:
##########
@@ -523,14 +523,14 @@ public static void main (String args[]) {
private int separatorIndex;
private String[] getOpenedFiles() {
- ArrayList opened = new ArrayList();
+ ArrayList<String> opened = new ArrayList<>();
Review Comment:
fexied
##########
ide/editor/demosrc/base/org/netbeans/editor/example/Editor.java:
##########
@@ -523,14 +523,14 @@ public static void main (String args[]) {
private int separatorIndex;
private String[] getOpenedFiles() {
- ArrayList opened = new ArrayList();
+ ArrayList<String> opened = new ArrayList<>();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1548456077
@vieiro The PR is ready to be reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5576: Installed some internal generics to fix some compiler warnings
URL: https://github.com/apache/netbeans/pull/5576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1454869724
Hi, please focus in https://github.com/apache/netbeans/pull/5598 before posting new PRs.
Once that one is ready for review you can then reopen this one.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker merged PR #5576:
URL: https://github.com/apache/netbeans/pull/5576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1763345916
up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1790417827
up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on code in PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#discussion_r1382596241
##########
ide/editor/demosrc/base/org/netbeans/editor/example/Editor.java:
##########
@@ -523,14 +523,14 @@ public static void main (String args[]) {
private int separatorIndex;
private String[] getOpenedFiles() {
- ArrayList opened = new ArrayList();
+ ArrayList<String> opened = new ArrayList<>();
Review Comment:
I would change this to a List..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1451907645
Cant push another PR while this waiting something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1576460611
@mbien
@BradWalker
PR is actual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5576: Installed some internal generics to fix some compiler warnings
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1454687003
inconsistent, corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1793769619
Overall, I'm always in support of code cleanup.
I would suggest that in the future you try and keep the changes in the same domain. This will make code review easier.
For example..
1 - If you say I'm going to clean up module XYZ, then it's appropriate to make a bunch of different changes in there.
2 - If you say I'm going to clean up the List generic, then keep the changes to cleaning up JUST the List interface.
It becomes harder for a volunteer like me to do a code review when a bunch of unrelated changes are requested. Doesn't mean the changes aren't useful, it's just harder to read/understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Installed some internal generics to fix some compiler warnings [netbeans]
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5576:
URL: https://github.com/apache/netbeans/pull/5576#issuecomment-1794738053
@BradWalker accepted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists