You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/01/09 12:33:36 UTC
[GitHub] activemq-artemis pull request: Add missing @Overrides
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/304
Add missing @Overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis overrides
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit d5983b430547af6b143d772797392c166e06c46f
Author: Ville Skyttä <vi...@iki.fi>
Date: 2016-01-09T11:33:03Z
Add missing @Overrides
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Add missing @Overrides
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Add missing @Overrides
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/304#issuecomment-170278575
I have my Eclipse config flag them as errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Add missing @Overrides
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/304#issuecomment-170279942
FWIW, IDEA seems to have such a setting as well, Editor -> Inspections -> Java -> Inheritance Issues -> Missing @Override annotation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Add missing @Overrides
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/304#issuecomment-170259143
How do you find those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---