[jira] [Commented] (WICKET-4019) Portlet Support 1.5

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404734#comment-13404734 ] 

Martin Grigorov commented on WICKET-4019:
-----------------------------------------

Here is a simple howto work with GitHub/Git so you can move your patches in the repo.

1) git clone https://github.com/wicketstuff/core.git (you need to do this just once. it is like 'svn checkout url')
2) git checkout core-1.5.x (this will switch to Wicket 1.5 branch of the project)
3) cd jdk-1.5-parent/portlet-parent/wicketstuff-portlet
4) edit the files
5) git ci -a (this is like 'svn commit' but it commits just locally)
6) git push (this uploads the commits in your local repo to the main repo)

That's it.
I hope you don't have problem with using the command line Git client. You can use your favorite IDE if you want but I think there is no reason to "pollute" your IDE with plugins just for a single commit/push that you do once in a while.

                
> Portlet Support 1.5
> -------------------
>
>                 Key: WICKET-4019
>                 URL: https://issues.apache.org/jira/browse/WICKET-4019
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Peter Pastrnak
>         Attachments: PortletServletRequestWrapper.java, ResponseState.java, Wicket - Portlet.htm, wicket-1.5.2.1.zip, wicket-portlet-1.5.0.zip, wicket-portlet-1.5.1.1.zip, wicket-portlet-1.5.1.2.zip, wicket-portlet-1.5.1.3.zip, wicket-portlet-1.5.1.4.zip, wicket-portlet-1.5.1.5.zip, wicket-portlet-1.5.1.zip, wicket-portlet-1.5.2.2.zip, wicket-portlet-1.5.2.4.zip, wicket-portlet-1.5.2.zip, wicket-portlet-1.5.5.0.zip, wicket-portlet-1.5.5.1.zip, wicket-portlet-1.5.7.1.zip, wicket-portlet-1.5.RC7.zip, with bind(this).jpg, without bind(this).jpg
>
>
> Url returned by the RequestMapper does not seem to be properly rendered, as it does not encode question mark character in the Url parameter value (I haven't checked the w3c spec, but at least Liferay Portal seems to require it to be encoded) 
> The reason is this definition in the UrlEncoder: 
>                         case QUERY : 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('/'); 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('?'); 
> Currently URL "http://host/file?param=a?b" would be encoded as "http://host/file?param=a?b", instead of "http://host/file?param=a%3Fb"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira