You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org> on 2023/03/05 07:22:53 UTC
[GitHub] [airflow] Abhishek-kumar-samsung opened a new pull request, #29927: Solution to docker errors that may come while running breeze
Abhishek-kumar-samsung opened a new pull request, #29927:
URL: https://github.com/apache/airflow/pull/29927
Solution to docker errors that may come while running breeze
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613733
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
I think it would be better to mention those in the `Prerequisite` section. I think we should even add a step of verifying if docker works for you there.
Typically that can be done via `docker run hello-world`. And this is happening when all is configured:
```
docker run hello-world
Hello from Docker!
This message shows that your installation appears to be working correctly.
To generate this message, Docker took the following steps:
1. The Docker client contacted the Docker daemon.
2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
(arm64v8)
3. The Docker daemon created a new container from that image which runs the
executable that produces the output you are currently reading.
4. The Docker daemon streamed that output to the Docker client, which sent it
to your terminal.
To try something more ambitious, you can run an Ubuntu container with:
$ docker run -it ubuntu bash
Share images, automate workflows, and more with a free Docker ID:
https://hub.docker.com/
For more examples and ideas, visit:
https://docs.docker.com/get-started/
```
BTW. Technically DOCKER_BUILDKIT=1 is not needed. Breeze automaticlaly add DOCKER_BUILDKIT=1 whenever it runs any `docker build` command. I wonder where you had to add it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125634947
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
I am not sure if `DOCKER_BUILDKIT=1` this would be required all the time. So in documentation, i have written **_If_** the error comes, then we can try this thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125631295
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Ah I see. I will take a look and fix it then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29927:
URL: https://github.com/apache/airflow/pull/29927#issuecomment-1455049755
You can try latest main and remove the DOCKER_BUILDKIT env and see if my solution works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29927:
URL: https://github.com/apache/airflow/pull/29927#issuecomment-1455012534
@Taragolis @eladkal @potiuk can you please review.
I have updated Breeze.rst to handle docker errors that may come while running breeze first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125632807
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
OK. No need. Fix here: https://github.com/apache/airflow/pull/29928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125631703
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Can you please run the build command with `--dry-run` (without the env set) @Abhishek-kumar-samsung ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613208
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
+
+- If docker not runing in python virtual environment
+- **Solution** : ``sudo chmod 666 /var/run/docker.sock``
+|
+- If error response from dockerfile parse error
+- **Solution** : ``export DOCKER_BUILDKIT=1``
+|
Review Comment:
yep that's worth mentioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125634717
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
`breeze ci-image build --upgrade-to-newer-dependencies --dry-run` this command?
This command is not giving any error.
This message comes at the end `Not updating build hash because we are in `dry_run` mode.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125620080
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Or maybe you can try to reproduce it now by removing the env var and send me the output ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613009
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
+
+- If docker not runing in python virtual environment
+- **Solution** : ``sudo chmod 666 /var/run/docker.sock``
Review Comment:
This is a very bad and extremely insecure solution. You should add your user to docker group. This is the right article describing it in detail https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125635614
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Ok, so should i remove that line from this PR?
Just put that one fix of `if docker not runing in python virtual environment`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125619981
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Do you remember which command you had problem with ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29927:
URL: https://github.com/apache/airflow/pull/29927#issuecomment-1455048743
@potiuk removed DOCKER_BUILDKIT=1 part from PR as you have resolved it in another PR. Just kept solution of docker not running in python environment.
can you please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125624380
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
@potiuk
I restarted laptop so DOCKER_BUILDKIT=1 this was not done, when i ran `breeze ci-image build --upgrade-to-newer-dependencies`
above error was coming, although docker run hello-world was working fine.
After doing export DOCKER_BUILDKIT=1, error is resolved, below is the result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29927:
URL: https://github.com/apache/airflow/pull/29927#issuecomment-1455051136
> You can try latest main and remove the DOCKER_BUILDKIT env and see if my solution works :)
Yes sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29927:
URL: https://github.com/apache/airflow/pull/29927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125616329
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Actually i was having this error `if error response from dockerfile parse error`, even though everything was fine with docker,
when i added `DOCKER_BUILDKIT=1`, then everything was working fine, so i thought to mention in documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125631703
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
Review Comment:
Can you please run the build command with `--dry-run` (without the evn set) @Abhishek-kumar-samsung ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613360
##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag):
Once this is complete, you should have ``breeze`` binary on your PATH and available to run by ``breeze``
command.
+**Docker errors that may come while running breeze**
+
+- If docker not runing in python virtual environment
+- **Solution** : ``sudo chmod 666 /var/run/docker.sock``
Review Comment:
oh okay, i will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org