[jira] [Commented] (TINKERPOP-1443) Use an API checker during build

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959180#comment-15959180 ] 

ASF GitHub Bot commented on TINKERPOP-1443:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/596

    TINKERPOP-1443 API Checker

    https://issues.apache.org/jira/browse/TINKERPOP-1443
    
    This is basically the continuation to #494 - didn't really change anything though @dkuppitz did get docker working. Travis seems ok with the build as well. No one seemed to have a problem with requiring maven 3.2.5 or better for our build (see the linked DISCUSS thread in JIRA), so keep in mind that if you run an earlier version it will cause trouble (only on the master branch obviously). 
    
    I guess we will need a release of 3.3.0 before we will have any real use out of this as breaking changes are allowed between our last release on 3.2.x and our future 3.3.0. 
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #596
    
----
commit 25752d23782652d55615540b15a1ee8bf0b3ac49
Author: Lukas Krejci <lk...@redhat.com>
Date:   2016-11-14T22:55:23Z

    Introduce Revapi API checks into the build.
    
    The API checker is set up to only check classes in org.apache.tinkerpop
    package (and sub packages) and is set up to ignore breaking changes
    on a minor version increase.
    
    It always reports non-public classes that leak into the API though.

commit ddb76a6092bd2e021b7f89cdb325b5350a9cbc60
Author: Lukas Krejci <lk...@redhat.com>
Date:   2016-11-15T10:21:34Z

    Make Travis use a newer version of Maven.

commit d73933bf4f103c61ba063cd616c29b354f21c4cf
Author: Lukas Krejci <lk...@redhat.com>
Date:   2016-11-28T22:28:06Z

    Finalize Revapi setup:
    * Switched off by default with only gremlin-core having it active
    * Explicitly sets the severity of problems to fail the build with to
      "potentiallyBreaking".
    * The parent pom only includes common setup.
    * Other setup (like what packages to include in a check and what changes
      to ignore because they are intentional) is externalized into
      per-module configuration files.

commit e42cfa7b041217ff244710aa20c752ec65ee3f61
Author: Lukas Krejci <lk...@redhat.com>
Date:   2017-01-06T22:24:57Z

    Upgrade to latest revapi versions.

commit a09c4c347c4e89a21b240f07bfb01178956970a0
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2017-04-06T12:40:05Z

    install Maven 3.3.9 as part of the Docker build process

----


> Use an API checker during build
> -------------------------------
>
>                 Key: TINKERPOP-1443
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1443
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.2.2
>            Reporter: Lukas Krejci
>            Assignee: stephen mallette
>
> Tinkerpop 3.2.2 changed the signature of the method {{GraphTraversal.hasLabel}} from {{(String...)}} to {{(String, String...)}}. While this is certainly an improvement, it is both source and binary incompatible change.
> I.e. even if every usage of {{hasLabel}} had at least one parameter in the user code, none of those calls will work until all the user code is recompiled using Tinkerpop 3.2.2.
> I don't know the versioning policy of Tinkerpop but changes like the above in a micro/patch release are generally unexpected.
> Please consider API checkers like http://revapi.org to warn about such incompatible API changes...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)