You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "shishkovilja (via GitHub)" <gi...@apache.org> on 2023/12/22 14:37:42 UTC
[PR] Ignite 21141 [ignite]
shishkovilja opened a new pull request, #11128:
URL: https://github.com/apache/ignite/pull/11128
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21141 MvccProcessor removal [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #11128:
URL: https://github.com/apache/ignite/pull/11128#discussion_r1436118780
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java:
##########
@@ -918,11 +917,7 @@ private boolean skipNearLocalUpdate(ClusterNode node, boolean moving) {
* @throws ClusterTopologyCheckedException If failed.
*/
private void checkCoordinatorVersion() throws ClusterTopologyCheckedException {
Review Comment:
Good point! I have removed this method.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/mvcc/MvccQueryTrackerImpl.java:
##########
@@ -289,13 +281,12 @@ private void onAffinityReady(@NotNull IgniteInternalFuture<AffinityTopologyVersi
/** */
private void ackQueryDone(MvccSnapshot snapshot) {
- if (snapshot != null)
- cctx.shared().coordinators().ackQueryDone(snapshot, id);
+ // No-op.
Review Comment:
Good point! I have removed this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21141 MvccProcessor removal [ignite]
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov merged PR #11128:
URL: https://github.com/apache/ignite/pull/11128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21141 MvccProcessor removal [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #11128:
URL: https://github.com/apache/ignite/pull/11128#discussion_r1436118821
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/mvcc/MvccQueryTrackerImpl.java:
##########
@@ -289,13 +281,12 @@ private void onAffinityReady(@NotNull IgniteInternalFuture<AffinityTopologyVersi
/** */
private void ackQueryDone(MvccSnapshot snapshot) {
- if (snapshot != null)
- cctx.shared().coordinators().ackQueryDone(snapshot, id);
+ // No-op.
}
/** */
@NotNull private MvccCoordinator coordinator() {
Review Comment:
Good point! I have removed this method.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -2740,19 +2739,7 @@ private boolean haveSystemTxForThread(long threadId) {
* @param state New state.
*/
public void setMvccState(IgniteInternalTx tx, TransactionState state) {
- if (cctx.kernalContext().clientNode() || tx.mvccSnapshot() == null || tx.near() && !tx.local())
- return;
-
- byte state0 = toMvccState(state);
-
- cctx.database().checkpointReadLock();
-
- try {
- cctx.coordinators().updateState(tx.mvccSnapshot(), state0, tx.local());
- }
- finally {
- cctx.database().checkpointReadUnlock();
- }
+ // No-op.
Review Comment:
Good point! I have removed this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21141 MvccProcessor removal [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #11128:
URL: https://github.com/apache/ignite/pull/11128#discussion_r1436118878
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -2774,10 +2761,7 @@ private byte toMvccState(TransactionState state) {
* @param tx Transaction.
*/
public void mvccFinish(IgniteTxAdapter tx) {
Review Comment:
Good point! I have removed this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21141 MvccProcessor removal [ignite]
Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #11128:
URL: https://github.com/apache/ignite/pull/11128#discussion_r1436098377
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxAbstractEnlistFuture.java:
##########
@@ -918,11 +917,7 @@ private boolean skipNearLocalUpdate(ClusterNode node, boolean moving) {
* @throws ClusterTopologyCheckedException If failed.
*/
private void checkCoordinatorVersion() throws ClusterTopologyCheckedException {
Review Comment:
Any reason to keep this empty method?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -2774,10 +2761,7 @@ private byte toMvccState(TransactionState state) {
* @param tx Transaction.
*/
public void mvccFinish(IgniteTxAdapter tx) {
Review Comment:
Any reason to keep this empty method?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/mvcc/MvccQueryTrackerImpl.java:
##########
@@ -289,13 +281,12 @@ private void onAffinityReady(@NotNull IgniteInternalFuture<AffinityTopologyVersi
/** */
private void ackQueryDone(MvccSnapshot snapshot) {
- if (snapshot != null)
- cctx.shared().coordinators().ackQueryDone(snapshot, id);
+ // No-op.
Review Comment:
Any reason to keep this empty method?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/mvcc/MvccQueryTrackerImpl.java:
##########
@@ -289,13 +281,12 @@ private void onAffinityReady(@NotNull IgniteInternalFuture<AffinityTopologyVersi
/** */
private void ackQueryDone(MvccSnapshot snapshot) {
- if (snapshot != null)
- cctx.shared().coordinators().ackQueryDone(snapshot, id);
+ // No-op.
}
/** */
@NotNull private MvccCoordinator coordinator() {
Review Comment:
Any reason to keep this empty method?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -2740,19 +2739,7 @@ private boolean haveSystemTxForThread(long threadId) {
* @param state New state.
*/
public void setMvccState(IgniteInternalTx tx, TransactionState state) {
- if (cctx.kernalContext().clientNode() || tx.mvccSnapshot() == null || tx.near() && !tx.local())
- return;
-
- byte state0 = toMvccState(state);
-
- cctx.database().checkpointReadLock();
-
- try {
- cctx.coordinators().updateState(tx.mvccSnapshot(), state0, tx.local());
- }
- finally {
- cctx.database().checkpointReadUnlock();
- }
+ // No-op.
Review Comment:
Any reason to keep this empty method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org